Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v: cleanup mark var as used operation #22842

Merged
merged 5 commits into from
Nov 12, 2024
Merged

v: cleanup mark var as used operation #22842

merged 5 commits into from
Nov 12, 2024

Conversation

felipensp
Copy link
Member

@felipensp felipensp commented Nov 12, 2024 •
edited
Loading

This PR aims cleanup mark var as used operation on Scope.
The logic was moved from parser to Scope.

Huly®: V_0.6-21287

@felipensp felipensp changed the title v: cached mark var as used v: cleanup mark var as used operation Nov 12, 2024
@felipensp felipensp marked this pull request as ready for review November 12, 2024 13:15
spytheman
spytheman reviewed Nov 12, 2024
View reviewed changes
vlib/v/ast/scope.v Outdated Show resolved Hide resolved
spytheman
spytheman approved these changes Nov 12, 2024
View reviewed changes
Copy link
Member

@spytheman spytheman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work.

@spytheman spytheman merged commit 9de8488 into vlang:master Nov 12, 2024
71 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spytheman spytheman spytheman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@felipensp @spytheman