Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cgen: fix array fixed code generation for more than 1 dimension #22876

Merged
merged 5 commits into from
Nov 17, 2024

Conversation

felipensp
Copy link
Member

@felipensp felipensp commented Nov 16, 2024

@felipensp felipensp marked this pull request as ready for review November 16, 2024 23:52
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good, the test does not work on master, but does here.

Comment on lines -2623 to +2642
g.write2('/*nili*/', '((void*)0)')
g.write2('/*nil*/', '((void*)0)')
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this comment needed at all?

Copy link
Member

@spytheman spytheman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work.

@spytheman spytheman merged commit 864845b into vlang:master Nov 17, 2024
72 checks passed
@felipensp felipensp deleted the fix_fixed_array_2_dims_ret branch November 17, 2024 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Creating explicit array from return values gives c error: declaration of an array of incomplete type elements
2 participants