chore: enable unused-parameter from revive

Signed-off-by: Matthieu MOREL <[email protected]>

.golangci.yaml

@@ -280,7 +280,6 @@ linters-settings:
       - name: unreachable-code
         disabled: false
       - name: unused-parameter
-        disabled: true
       - name: use-any
         disabled: true
       - name: var-declaration

internal/hook/item_hook_handler.go

@@ -308,12 +308,12 @@ func (h *DefaultItemHookHandler) HandleHooks(
 type NoOpItemHookHandler struct{}
 
 func (h *NoOpItemHookHandler) HandleHooks(
-	log logrus.FieldLogger,
-	groupResource schema.GroupResource,
-	obj runtime.Unstructured,
-	resourceHooks []ResourceHook,
-	phase HookPhase,
-	hookTracker *HookTracker,
+	_ logrus.FieldLogger,
+	_ schema.GroupResource,
+	_ runtime.Unstructured,
+	_ []ResourceHook,
+	_ HookPhase,
+	_ *HookTracker,
 ) error {
 	return nil
 }

internal/hook/wait_exec_hook_handler.go

@@ -220,7 +220,7 @@ func (e *DefaultWaitExecHookHandler) HandleHooks(
 		UpdateFunc: func(_, newObj interface{}) {
 			handler(newObj)
 		},
-		DeleteFunc: func(obj interface{}) {
+		DeleteFunc: func(_ interface{}) {
 			err := fmt.Errorf("pod %s deleted before all hooks were executed", kube.NamespaceAndName(pod))
 			log.Error(err)
 			cancel()

internal/hook/wait_exec_hook_handler_test.go

@@ -42,7 +42,7 @@ type fakeListWatchFactory struct {
 	lw cache.ListerWatcher
 }
 
-func (f *fakeListWatchFactory) NewListWatch(ns string, selector fields.Selector) cache.ListerWatcher {
+func (f *fakeListWatchFactory) NewListWatch(_ string, selector fields.Selector) cache.ListerWatcher {
 	return f.lw
 }
 

internal/storage/storagelocation.go

@@ -94,7 +94,7 @@ func ListBackupStorageLocations(ctx context.Context, kbClient client.Client, nam
 	return locations, nil
 }
 
-func GetDefaultBackupStorageLocations(ctx context.Context, kbClient client.Client, namespace string) (*velerov1api.BackupStorageLocationList, error) {
+func GetDefaultBackupStorageLocations(_ context.Context, kbClient client.Client, namespace string) (*velerov1api.BackupStorageLocationList, error) {
 	locations := new(velerov1api.BackupStorageLocationList)
 	defaultLocations := new(velerov1api.BackupStorageLocationList)
 	if err := kbClient.List(context.Background(), locations, &client.ListOptions{Namespace: namespace}); err != nil {

pkg/backup/actions/backup_pv_action.go

@@ -48,7 +48,7 @@ func (a *PVCAction) AppliesTo() (velero.ResourceSelector, error) {
 
 // Execute finds the PersistentVolume bound by the provided
 // PersistentVolumeClaim, if any, and backs it up
-func (a *PVCAction) Execute(item runtime.Unstructured, backup *v1.Backup) (runtime.Unstructured, []velero.ResourceIdentifier, error) {
+func (a *PVCAction) Execute(item runtime.Unstructured, _ *v1.Backup) (runtime.Unstructured, []velero.ResourceIdentifier, error) {
 	a.log.Info("Executing PVCAction")
 
 	pvc := new(corev1api.PersistentVolumeClaim)

pkg/backup/actions/pod_action.go

@@ -47,7 +47,7 @@ func (a *PodAction) AppliesTo() (velero.ResourceSelector, error) {
 // Execute scans the pod's spec.volumes for persistentVolumeClaim volumes and returns a
 // ResourceIdentifier list containing references to all of the persistentVolumeClaim volumes used by
 // the pod. This ensures that when a pod is backed up, all referenced PVCs are backed up too.
-func (a *PodAction) Execute(item runtime.Unstructured, backup *v1.Backup) (runtime.Unstructured, []velero.ResourceIdentifier, error) {
+func (a *PodAction) Execute(item runtime.Unstructured, _ *v1.Backup) (runtime.Unstructured, []velero.ResourceIdentifier, error) {
 	a.log.Info("Executing podAction")
 	defer a.log.Info("Done executing podAction")
 

pkg/backup/actions/remap_crd_version_action.go

@@ -57,7 +57,7 @@ func (a *RemapCRDVersionAction) AppliesTo() (velero.ResourceSelector, error) {
 }
 
 // Execute executes logic necessary to check a CustomResourceDefinition and inspect it for characteristics that necessitate saving it as v1beta1 instead of v1.
-func (a *RemapCRDVersionAction) Execute(item runtime.Unstructured, backup *v1.Backup) (runtime.Unstructured, []velero.ResourceIdentifier, error) {
+func (a *RemapCRDVersionAction) Execute(item runtime.Unstructured, _ *v1.Backup) (runtime.Unstructured, []velero.ResourceIdentifier, error) {
 	a.logger.Info("Executing RemapCRDVersionAction")
 
 	// This plugin is only relevant for CRDs retrieved from the v1 endpoint that were installed via the v1beta1

pkg/backup/actions/service_account_action.go

@@ -57,7 +57,7 @@ func (a *ServiceAccountAction) AppliesTo() (velero.ResourceSelector, error) {
 // Execute checks for any ClusterRoleBindings that have this service account as a subject, and
 // adds the ClusterRoleBinding and associated ClusterRole to the list of additional items to
 // be backed up.
-func (a *ServiceAccountAction) Execute(item runtime.Unstructured, backup *v1.Backup) (runtime.Unstructured, []velero.ResourceIdentifier, error) {
+func (a *ServiceAccountAction) Execute(item runtime.Unstructured, _ *v1.Backup) (runtime.Unstructured, []velero.ResourceIdentifier, error) {
 	a.log.Info("Running ServiceAccountAction")
 	defer a.log.Info("Done running ServiceAccountAction")
 

pkg/backup/backup_test.go

@@ -2082,7 +2082,7 @@ func TestBackupActionAdditionalItems(t *testing.T) {
 			},
 			actions: []biav2.BackupItemAction{
 				&pluggableAction{
-					executeFunc: func(item runtime.Unstructured, backup *velerov1.Backup) (runtime.Unstructured, []velero.ResourceIdentifier, string, []velero.ResourceIdentifier, error) {
+					executeFunc: func(item runtime.Unstructured, _ *velerov1.Backup) (runtime.Unstructured, []velero.ResourceIdentifier, string, []velero.ResourceIdentifier, error) {
 						additionalItems := []velero.ResourceIdentifier{
 							{GroupResource: kuberesource.PersistentVolumes, Name: "pv-1"},
 							{GroupResource: kuberesource.PersistentVolumes, Name: "pv-2"},
@@ -2113,7 +2113,7 @@ func TestBackupActionAdditionalItems(t *testing.T) {
 			actions: []biav2.BackupItemAction{
 				&pluggableAction{
 					selector: velero.ResourceSelector{IncludedNamespaces: []string{"ns-1"}},
-					executeFunc: func(item runtime.Unstructured, backup *velerov1.Backup) (runtime.Unstructured, []velero.ResourceIdentifier, string, []velero.ResourceIdentifier, error) {
+					executeFunc: func(item runtime.Unstructured, _ *velerov1.Backup) (runtime.Unstructured, []velero.ResourceIdentifier, string, []velero.ResourceIdentifier, error) {
 						additionalItems := []velero.ResourceIdentifier{
 							{GroupResource: kuberesource.Pods, Namespace: "ns-4", Name: "pod-4"},
 							{GroupResource: kuberesource.Pods, Namespace: "ns-5", Name: "pod-5"},
@@ -2520,7 +2520,7 @@ func TestItemBlockActionRelatedItems(t *testing.T) {
 			actions: []ibav1.ItemBlockAction{
 				&pluggableIBA{
 					selector: velero.ResourceSelector{IncludedNamespaces: []string{"ns-1"}},
-					getRelatedItemsFunc: func(item runtime.Unstructured, backup *velerov1.Backup) ([]velero.ResourceIdentifier, error) {
+					getRelatedItemsFunc: func(_ runtime.Unstructured, backup *velerov1.Backup) ([]velero.ResourceIdentifier, error) {
 						relatedItems := []velero.ResourceIdentifier{
 							{GroupResource: kuberesource.Pods, Namespace: "ns-2", Name: "pod-2"},
 							{GroupResource: kuberesource.Pods, Namespace: "ns-3", Name: "pod-3"},
@@ -2551,7 +2551,7 @@ func TestItemBlockActionRelatedItems(t *testing.T) {
 			},
 			actions: []ibav1.ItemBlockAction{
 				&pluggableIBA{
-					getRelatedItemsFunc: func(item runtime.Unstructured, backup *velerov1.Backup) ([]velero.ResourceIdentifier, error) {
+					getRelatedItemsFunc: func(_ runtime.Unstructured, backup *velerov1.Backup) ([]velero.ResourceIdentifier, error) {
 						relatedItems := []velero.ResourceIdentifier{
 							{GroupResource: kuberesource.Pods, Namespace: "ns-2", Name: "pod-2"},
 							{GroupResource: kuberesource.Pods, Namespace: "ns-3", Name: "pod-3"},
@@ -2581,7 +2581,7 @@ func TestItemBlockActionRelatedItems(t *testing.T) {
 			},
 			actions: []ibav1.ItemBlockAction{
 				&pluggableIBA{
-					getRelatedItemsFunc: func(item runtime.Unstructured, backup *velerov1.Backup) ([]velero.ResourceIdentifier, error) {
+					getRelatedItemsFunc: func(_ runtime.Unstructured, backup *velerov1.Backup) ([]velero.ResourceIdentifier, error) {
 						relatedItems := []velero.ResourceIdentifier{
 							{GroupResource: kuberesource.PersistentVolumes, Name: "pv-1"},
 							{GroupResource: kuberesource.PersistentVolumes, Name: "pv-2"},
@@ -2614,7 +2614,7 @@ func TestItemBlockActionRelatedItems(t *testing.T) {
 			},
 			actions: []ibav1.ItemBlockAction{
 				&pluggableIBA{
-					getRelatedItemsFunc: func(item runtime.Unstructured, backup *velerov1.Backup) ([]velero.ResourceIdentifier, error) {
+					getRelatedItemsFunc: func(_ runtime.Unstructured, backup *velerov1.Backup) ([]velero.ResourceIdentifier, error) {
 						relatedItems := []velero.ResourceIdentifier{
 							{GroupResource: kuberesource.PersistentVolumes, Name: "pv-1"},
 							{GroupResource: kuberesource.PersistentVolumes, Name: "pv-2"},
@@ -2644,7 +2644,7 @@ func TestItemBlockActionRelatedItems(t *testing.T) {
 			},
 			actions: []ibav1.ItemBlockAction{
 				&pluggableIBA{
-					getRelatedItemsFunc: func(item runtime.Unstructured, backup *velerov1.Backup) ([]velero.ResourceIdentifier, error) {
+					getRelatedItemsFunc: func(_ runtime.Unstructured, backup *velerov1.Backup) ([]velero.ResourceIdentifier, error) {
 						relatedItems := []velero.ResourceIdentifier{
 							{GroupResource: kuberesource.PersistentVolumes, Name: "pv-1"},
 							{GroupResource: kuberesource.PersistentVolumes, Name: "pv-2"},
@@ -2675,7 +2675,7 @@ func TestItemBlockActionRelatedItems(t *testing.T) {
 			},
 			actions: []ibav1.ItemBlockAction{
 				&pluggableIBA{
-					getRelatedItemsFunc: func(item runtime.Unstructured, backup *velerov1.Backup) ([]velero.ResourceIdentifier, error) {
+					getRelatedItemsFunc: func(_ runtime.Unstructured, backup *velerov1.Backup) ([]velero.ResourceIdentifier, error) {
 						relatedItems := []velero.ResourceIdentifier{
 							{GroupResource: kuberesource.PersistentVolumes, Name: "pv-1"},
 							{GroupResource: kuberesource.PersistentVolumes, Name: "pv-2"},
@@ -2706,7 +2706,7 @@ func TestItemBlockActionRelatedItems(t *testing.T) {
 			actions: []ibav1.ItemBlockAction{
 				&pluggableIBA{
 					selector: velero.ResourceSelector{IncludedNamespaces: []string{"ns-1"}},
-					getRelatedItemsFunc: func(item runtime.Unstructured, backup *velerov1.Backup) ([]velero.ResourceIdentifier, error) {
+					getRelatedItemsFunc: func(_ runtime.Unstructured, backup *velerov1.Backup) ([]velero.ResourceIdentifier, error) {
 						relatedItems := []velero.ResourceIdentifier{
 							{GroupResource: kuberesource.Pods, Namespace: "ns-4", Name: "pod-4"},
 							{GroupResource: kuberesource.Pods, Namespace: "ns-5", Name: "pod-5"},
@@ -2818,7 +2818,7 @@ func (vs *fakeVolumeSnapshotter) WithVolume(pvName, id, az, volumeType string, i
 }
 
 // Init is a no-op.
-func (*fakeVolumeSnapshotter) Init(config map[string]string) error {
+func (*fakeVolumeSnapshotter) Init(_ map[string]string) error {
 	return nil
 }
 
@@ -2838,7 +2838,7 @@ func (vs *fakeVolumeSnapshotter) GetVolumeID(pv runtime.Unstructured) (string, e
 // CreateSnapshot looks up the volume in the Volume map. If it's not found, an error is
 // returned; if snapshotErr is true on the result, an error is returned; otherwise,
 // a snapshotID of "<volumeID>-snapshot" is returned.
-func (vs *fakeVolumeSnapshotter) CreateSnapshot(volumeID, volumeAZ string, tags map[string]string) (snapshotID string, err error) {
+func (vs *fakeVolumeSnapshotter) CreateSnapshot(volumeID, volumeAZ string, _ map[string]string) (snapshotID string, err error) {
 	vi, ok := vs.Volumes[volumeIdentifier{volumeID: volumeID, volumeAZ: volumeAZ}]
 	if !ok {
 		return "", errors.New("volume not found")

pkg/cmd/cli/backup/describe.go

@@ -50,7 +50,7 @@ func NewDescribeCommand(f client.Factory, use string) *cobra.Command {
 	c := &cobra.Command{
 		Use:   use + " [NAME1] [NAME2] [NAME...]",
 		Short: "Describe backups",
-		Run: func(c *cobra.Command, args []string) {
+		Run: func(_ *cobra.Command, args []string) {
 			kbClient, err := f.KubebuilderClient()
 			cmd.CheckError(err)
 

pkg/cmd/cli/backup/download.go

@@ -83,7 +83,7 @@ func (o *DownloadOptions) BindFlags(flags *pflag.FlagSet) {
 	flags.StringVar(&o.caCertFile, "cacert", o.caCertFile, "Path to a certificate bundle to use when verifying TLS connections.")
 }
 
-func (o *DownloadOptions) Validate(c *cobra.Command, args []string, f client.Factory) error {
+func (o *DownloadOptions) Validate(_ *cobra.Command, args []string, f client.Factory) error {
 	kbClient, err := f.KubebuilderClient()
 	cmd.CheckError(err)
 
@@ -114,7 +114,7 @@ func (o *DownloadOptions) Complete(args []string) error {
 	return nil
 }
 
-func (o *DownloadOptions) Run(c *cobra.Command, f client.Factory) error {
+func (o *DownloadOptions) Run(_ *cobra.Command, f client.Factory) error {
 	kbClient, err := f.KubebuilderClient()
 	cmd.CheckError(err)
 

pkg/cmd/cli/backup/logs.go

@@ -60,7 +60,7 @@ func (l *LogsOptions) BindFlags(flags *pflag.FlagSet) {
 	flags.StringVar(&l.CaCertFile, "cacert", l.CaCertFile, "Path to a certificate bundle to use when verifying TLS connections.")
 }
 
-func (l *LogsOptions) Run(c *cobra.Command, f client.Factory) error {
+func (l *LogsOptions) Run(_ *cobra.Command, f client.Factory) error {
 	backup := new(velerov1api.Backup)
 	err := l.Client.Get(context.TODO(), kbclient.ObjectKey{Namespace: f.Namespace(), Name: l.BackupName}, backup)
 	if apierrors.IsNotFound(err) {

pkg/cmd/cli/bug/bug.go

@@ -107,7 +107,7 @@ func NewCommand() *cobra.Command {
 		Use:   "bug",
 		Short: "Report a Velero bug",
 		Long:  "Open a browser window to report a Velero bug",
-		Run: func(c *cobra.Command, args []string) {
+		Run: func(_ *cobra.Command, _ []string) {
 			kubectlVersion, err := getKubectlVersion()
 			if err != nil {
 				// we don't want to prevent the user from submitting a bug

pkg/cmd/cli/client/config/get.go

@@ -30,7 +30,7 @@ func NewGetCommand() *cobra.Command {
 	c := &cobra.Command{
 		Use:   "get [KEY 1] [KEY 2] [...]",
 		Short: "Get client configuration file values",
-		Run: func(c *cobra.Command, args []string) {
+		Run: func(_ *cobra.Command, args []string) {
 			config, err := client.LoadConfig()
 			cmd.CheckError(err)
 

pkg/cmd/cli/client/config/set.go

@@ -32,7 +32,7 @@ func NewSetCommand() *cobra.Command {
 		Use:   "set KEY=VALUE [KEY=VALUE]...",
 		Short: "Set client configuration file values",
 		Args:  cobra.MinimumNArgs(1),
-		Run: func(c *cobra.Command, args []string) {
+		Run: func(_ *cobra.Command, args []string) {
 			config, err := client.LoadConfig()
 			cmd.CheckError(err)
 

pkg/cmd/cli/debug/debug.go

@@ -153,7 +153,7 @@ func NewCommand(f client.Factory) *cobra.Command {
 		Short: "Generate debug bundle",
 		Long: `Generate a tarball containing the logs of velero deployment, plugin logs, node-agent DaemonSet, 
 specs of resources created by velero server, and optionally the logs of backup and restore.`,
-		Run: func(c *cobra.Command, args []string) {
+		Run: func(c *cobra.Command, _ []string) {
 			flags := c.Flags()
 			err := o.complete(f, flags)
 			cmd.CheckError(err)

pkg/cmd/cli/delete_options.go

@@ -54,7 +54,7 @@ func (o *DeleteOptions) Complete(f client.Factory, args []string) error {
 }
 
 // Validate validates the fields of the DeleteOptions struct.
-func (o *DeleteOptions) Validate(c *cobra.Command, f client.Factory, args []string) error {
+func (o *DeleteOptions) Validate(_ *cobra.Command, _ client.Factory, args []string) error {
 	if o.Client == nil {
 		return errors.New("velero client is not set; unable to proceed")
 	}

pkg/cmd/cli/schedule/describe.go

@@ -37,7 +37,7 @@ func NewDescribeCommand(f client.Factory, use string) *cobra.Command {
 	c := &cobra.Command{
 		Use:   use + " [NAME1] [NAME2] [NAME...]",
 		Short: "Describe schedules",
-		Run: func(c *cobra.Command, args []string) {
+		Run: func(_ *cobra.Command, args []string) {
 			crClient, err := f.KubebuilderClient()
 			cmd.CheckError(err)
 

pkg/cmd/cli/schedule/pause.go

@@ -53,7 +53,7 @@ func NewPauseCommand(f client.Factory, use string) *cobra.Command {
 
   # Pause all schedules.
   velero schedule pause --all`,
-		Run: func(c *cobra.Command, args []string) {
+		Run: func(_ *cobra.Command, args []string) {
 			cmd.CheckError(o.Complete(args))
 			cmd.CheckError(o.Validate())
 			cmd.CheckError(runPause(f, o, true, pauseOpts.SkipOptions.SkipImmediately.Value))

pkg/cmd/cli/schedule/unpause.go

@@ -42,7 +42,7 @@ func NewUnpauseCommand(f client.Factory, use string) *cobra.Command {
 
   # Unpause all schedules.
   velero schedule unpause --all`,
-		Run: func(c *cobra.Command, args []string) {
+		Run: func(_ *cobra.Command, args []string) {
 			cmd.CheckError(o.Complete(args))
 			cmd.CheckError(o.Validate())
 			cmd.CheckError(runPause(f, o, false, pauseOpts.SkipOptions.SkipImmediately.Value))

pkg/cmd/cli/snapshotlocation/create.go

@@ -77,7 +77,7 @@ func (o *CreateOptions) BindFlags(flags *pflag.FlagSet) {
 	flags.Var(&o.Credential, "credential", "The credential to be used by this location as a key-value pair, where the key is the Kubernetes Secret name, and the value is the data key name within the Secret. Optional, one value only.")
 }
 
-func (o *CreateOptions) Validate(c *cobra.Command, args []string, f client.Factory) error {
+func (o *CreateOptions) Validate(c *cobra.Command, _ []string, _ client.Factory) error {
 	if err := output.ValidateFlags(c); err != nil {
 		return err
 	}
@@ -93,7 +93,7 @@ func (o *CreateOptions) Validate(c *cobra.Command, args []string, f client.Facto
 	return nil
 }
 
-func (o *CreateOptions) Complete(args []string, f client.Factory) error {
+func (o *CreateOptions) Complete(args []string, _ client.Factory) error {
 	o.Name = args[0]
 	return nil
 }

pkg/cmd/cli/snapshotlocation/set.go

@@ -67,7 +67,7 @@ func (o *SetOptions) BindFlags(flags *pflag.FlagSet) {
 	flags.Var(&o.Credential, "credential", "Sets the credential to be used by this location as a key-value pair, where the key is the Kubernetes Secret name, and the value is the data key name within the Secret. Optional, one value only.")
 }
 
-func (o *SetOptions) Validate(c *cobra.Command, args []string, f client.Factory) error {
+func (o *SetOptions) Validate(c *cobra.Command, _ []string, _ client.Factory) error {
 	if err := output.ValidateFlags(c); err != nil {
 		return err
 	}
@@ -79,12 +79,12 @@ func (o *SetOptions) Validate(c *cobra.Command, args []string, f client.Factory)
 	return nil
 }
 
-func (o *SetOptions) Complete(args []string, f client.Factory) error {
+func (o *SetOptions) Complete(args []string, _ client.Factory) error {
 	o.Name = args[0]
 	return nil
 }
 
-func (o *SetOptions) Run(c *cobra.Command, f client.Factory) error {
+func (o *SetOptions) Run(_ *cobra.Command, f client.Factory) error {
 	kbClient, err := f.KubebuilderClient()
 	if err != nil {
 		return err

pkg/cmd/cli/version/version.go

@@ -40,7 +40,7 @@ func NewCommand(f client.Factory) *cobra.Command {
 	c := &cobra.Command{
 		Use:   "version",
 		Short: "Print the velero version and associated image",
-		Run: func(c *cobra.Command, args []string) {
+		Run: func(_ *cobra.Command, args []string) {
 			var kbClient kbclient.Client
 			if !clientOnly {
 				var err error

pkg/cmd/util/output/backup_describer_test.go

@@ -373,7 +373,7 @@ func TestDescribeNativeSnapshots(t *testing.T) {
 	}
 
 	for _, tc := range testcases {
-		t.Run(tc.name, func(tt *testing.T) {
+		t.Run(tc.name, func(t *testing.T) {
 			d := &Describer{
 				Prefix: "",
 				out:    &tabwriter.Writer{},
@@ -541,7 +541,7 @@ func TestCSISnapshots(t *testing.T) {
 	}
 
 	for _, tc := range testcases {
-		t.Run(tc.name, func(tt *testing.T) {
+		t.Run(tc.name, func(t *testing.T) {
 			d := &Describer{
 				Prefix: "",
 				out:    &tabwriter.Writer{},

pkg/nodeagent/node_agent_test.go

@@ -70,7 +70,7 @@ func TestIsRunning(t *testing.T) {
 				{
 					verb:     "get",
 					resource: "daemonsets",
-					reactorFunc: func(action clientTesting.Action) (handled bool, ret runtime.Object, err error) {
+					reactorFunc: func(_ clientTesting.Action) (handled bool, ret runtime.Object, err error) {
 						return true, nil, errors.New("fake-get-error")
 					},
 				},
@@ -262,7 +262,7 @@ func TestGetConfigs(t *testing.T) {
 				{
 					verb:     "get",
 					resource: "configmaps",
-					reactorFunc: func(action clientTesting.Action) (handled bool, ret runtime.Object, err error) {
+					reactorFunc: func(_ clientTesting.Action) (handled bool, ret runtime.Object, err error) {
 						return true, nil, errors.New("fake-get-error")
 					},
 				},

pkg/persistence/in_memory_object_store.go

@@ -152,7 +152,7 @@ func (o *inMemoryObjectStore) DeleteObject(bucket, key string) error {
 	return nil
 }
 
-func (o *inMemoryObjectStore) CreateSignedURL(bucket, key string, ttl time.Duration) (string, error) {
+func (o *inMemoryObjectStore) CreateSignedURL(bucket, key string, _ time.Duration) (string, error) {
 	bucketData, ok := o.Data[bucket]
 	if !ok {
 		return "", errors.New("bucket not found")