This repository has been archived by the owner on Apr 25, 2022. It is now read-only.
Add support for Visual Studio compilation using vcpkg for dependencies #196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
commented
Sep 26, 2021
| @@ -90,7 +95,6 @@ endif() | |||
| configure_file("${CMAKE_SOURCE_DIR}/src/version.h.in" "${CMAKE_BINARY_DIR}/generated/version.h" @ONLY) | |||
| include_directories(${CMAKE_BINARY_DIR}/generated) | |||
|
|
|||
| set(CMAKE_SOURCE_DIR "${CMAKE_BINARY_DIR}/../") | |||
There was a problem hiding this comment.
I'm not sure why this line was added in the first place, but it is problematic because Visual Studio places the binary directory several levels deeper. It's also completely redundant as far as I can see.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some compilation and CMake fixes to allow the project to be built with Visual Studio 2019.
I also made building the test suite optional and turned it off by default.