Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

backend: add test for lyric #625

Merged
merged 12 commits into from
Jan 1, 2025
Merged

backend: add test for lyric #625

merged 12 commits into from
Jan 1, 2025

Conversation

vnghia
Copy link
Owner

@vnghia vnghia commented Jan 1, 2025

No description provided.

Copy link

codecov bot commented Jan 1, 2025

Codecov Report

Attention: Patch coverage is 82.60870% with 40 lines in your changes missing coverage. Please review.

Project coverage is 76.06%. Comparing base (310e6d8) to head (cf6ca7a).
Report is 4 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
nghe-backend/src/file/lyric/mod.rs 86.61% 0 Missing and 19 partials ⚠️
...src/route/media_retrieval/get_lyrics_by_song_id.rs 0.00% 9 Missing ⚠️
nghe-backend/src/scan/scanner.rs 50.00% 0 Missing and 5 partials ⚠️
nghe-backend/src/file/audio/information.rs 57.14% 0 Missing and 3 partials ⚠️
nghe-backend/src/orm/lyrics.rs 93.10% 0 Missing and 2 partials ⚠️
nghe-backend/src/file/audio/extract/file.rs 66.66% 0 Missing and 1 partial ⚠️
nghe-backend/src/file/audio/extract/mod.rs 83.33% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #625      +/-   ##
==========================================
+ Coverage   74.71%   76.06%   +1.35%     
==========================================
  Files         185      185              
  Lines        5308     5407      +99     
  Branches     5308     5407      +99     
==========================================
+ Hits         3966     4113     +147     
+ Misses        804      730      -74     
- Partials      538      564      +26     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vnghia vnghia merged commit 8d16e5b into main Jan 1, 2025
15 checks passed
@vnghia vnghia deleted the lyrics branch January 1, 2025 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant