-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Liger-kernel] Add an option to use _apply_liger_kernel_to_instance()
to load model
#133
Merged
vermouth1992
merged 9 commits into
volcengine:main
from
hongpeng-guo:hpguo/add_liger_kernel
Jan 30, 2025
+66
−0
Merged
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
516a922
Add option to use AutoLigerKernelForCausalLM to load model
hongpeng-guo a039564
remove typo
hongpeng-guo 562b62a
add a test case with liger
hongpeng-guo e5a0852
use the _apply_fn to apply liger kernel
hongpeng-guo cb6374a
format
hongpeng-guo 8a7a0ac
add + to the use_liger flag
hongpeng-guo 5ee6824
add liger test to ci
hongpeng-guo 2b1f51c
add a TODO
hongpeng-guo fa02313
update requirements and pyproject, remove try catch import liger-kernel
hongpeng-guo File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -13,3 +13,4 @@ tensordict<0.6 | |
transformers<4.48 | ||
vllm<=0.6.3 | ||
wandb | ||
liger-kernel |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,52 @@ | ||
set -x | ||
|
||
export VLLM_ATTENTION_BACKEND=XFORMERS | ||
|
||
python3 -m verl.trainer.main_ppo \ | ||
data.train_files=$HOME/data/gsm8k/train.parquet \ | ||
data.val_files=$HOME/data/gsm8k/test.parquet \ | ||
data.train_batch_size=1024 \ | ||
data.val_batch_size=1312 \ | ||
data.max_prompt_length=512 \ | ||
data.max_response_length=512 \ | ||
data.return_raw_chat=True \ | ||
actor_rollout_ref.model.path=Qwen/Qwen2.5-0.5B \ | ||
actor_rollout_ref.actor.optim.lr=1e-6 \ | ||
actor_rollout_ref.model.use_remove_padding=True \ | ||
+actor_rollout_ref.model.use_liger=True \ | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The flag for |
||
actor_rollout_ref.actor.optim.lr_warmup_steps_ratio=0.1 \ | ||
actor_rollout_ref.actor.ppo_mini_batch_size=256 \ | ||
actor_rollout_ref.actor.ppo_micro_batch_size=32 \ | ||
actor_rollout_ref.actor.fsdp_config.param_offload=False \ | ||
actor_rollout_ref.actor.fsdp_config.grad_offload=False \ | ||
actor_rollout_ref.actor.fsdp_config.optimizer_offload=False \ | ||
actor_rollout_ref.rollout.log_prob_micro_batch_size=128 \ | ||
actor_rollout_ref.rollout.tensor_model_parallel_size=2 \ | ||
actor_rollout_ref.rollout.name=vllm \ | ||
actor_rollout_ref.rollout.gpu_memory_utilization=0.4 \ | ||
actor_rollout_ref.ref.log_prob_micro_batch_size=128 \ | ||
actor_rollout_ref.ref.fsdp_config.param_offload=True \ | ||
critic.optim.lr=1e-5 \ | ||
critic.model.use_remove_padding=True \ | ||
critic.optim.lr_warmup_steps_ratio=0.05 \ | ||
critic.model.path=Qwen/Qwen2.5-0.5B \ | ||
critic.model.enable_gradient_checkpointing=False \ | ||
critic.ppo_micro_batch_size=32 \ | ||
critic.model.fsdp_config.param_offload=False \ | ||
critic.model.fsdp_config.grad_offload=False \ | ||
critic.model.fsdp_config.optimizer_offload=False \ | ||
reward_model.enable=True \ | ||
reward_model.model.path=Qwen/Qwen2.5-0.5B\ | ||
reward_model.model.use_remove_padding=True \ | ||
reward_model.model.fsdp_config.param_offload=True \ | ||
reward_model.micro_batch_size=16 \ | ||
algorithm.kl_ctrl.kl_coef=0.001 \ | ||
trainer.critic_warmup=0 \ | ||
trainer.logger=['console'] \ | ||
+trainer.val_before_train=False \ | ||
trainer.project_name='verl_example' \ | ||
trainer.experiment_name='Qwen2.5-0.5B-ci_hybrid_rm' \ | ||
trainer.n_gpus_per_node=8 \ | ||
trainer.nnodes=1 \ | ||
trainer.save_freq=-1 \ | ||
trainer.total_training_steps=1 $@ |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add this test to CI and make sure liger-kernel is toggled?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, added this test to
.github/workflows/e2e_gsm8k.yml
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess liger-kernel has to be added to setup.py and project.toml