Skip to content

Commit

Permalink
feat(objectionary#528): add one more puzzle
Browse files Browse the repository at this point in the history
  • Loading branch information
volodya-lombrozo committed Apr 3, 2024
1 parent 1324d4e commit a61520a
Showing 1 changed file with 9 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,15 @@ MethodVisitor visitMethod(
* @param signature Method signature.
* @param exceptions Method exceptions.
* @return Method visitor.
* @checkstyle ParameterNumberCheck (5 lines)
* @todo #528:90min Remove ad-hoc solution for method frames, stack and locals computation.
* This method is a workaround for the issue with the ASM library that doesn't allow
* to compute frames and stack values per method basis. Here I use reflection to change
* the computation mode to COMPUTE_ALL_FRAMES and then restore it back to the original value.
* This is a hacky solution and should be removed once the issue is fixed in the ASM library.
* Another option is to compute all this values ourselves.
* You can read more about this issue here:
* https://stackoverflow.com/questions/78262674/how-to-mix-manual-and-automatic-calculation-of-max-locals-max-stack-and-frames
* @checkstyle ParameterNumberCheck (25 lines)
*/
@SuppressWarnings("PMD.AvoidAccessibilityAlteration")
private MethodVisitor visitMethodWithoutFrames(
Expand Down

0 comments on commit a61520a

Please sign in to comment.