Service status is not working when using init scripts #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… returning a state of 'stopped' This was due to the jps task always having an exit status of 1 even thou the jira service was running. have chaged this to simply look for a process owened by the jira user
| ps -ef |grep $SERVICE |grep -v grep |awk '{ print $2 }' | <%= scope.lookupvar('jira::javahome') %>/bin/jps |grep -v Jps |grep -v grep > /dev/null | ||
| RETVAL=$? | ||
| if [ $RETVAL -eq 0 ];then | ||
| RETVAL=`ps -ef |grep $SERVICE |grep -v grep |grep atlassian-jira |grep ^<%= scope.lookupvar('jira::user')%> |wc -l` |
There was a problem hiding this comment.
this line could just be:
RETVAL=`pgrep -u <%= scope.lookupvar('jira::user')%> -f atlassian-jira`There was a problem hiding this comment.
come to think of it, this whole set of cascaded ifs could be that line…
|
Hello: What's the status of this PR? |
|
HI @jlcox1970, could you take a look at the improvements @igalic mentioned? |
Also shrink it down so that we run one pgrep to find the task or set it to 0
Also shrink it down so that we run one pgrep to find the task or set it to 0 - Accidental typo in function
|
@bastelfreak I have made some more changes in line of what @igalic was suggesting |
|
thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turns out that the check for the status of the jira server was always returning a state of 'stopped'
This was due to the jps task always having an exit status of 1 even thou the jira service was running.
have chaged this to simply look for a process owened by the jira user