postfix exporter support

[anarcat]

This provides support in the Puppet module for the Postfix exporter. It is a fairly trivial patch, based on the apache_exporter class with small changes.

It does follow the work in #303 to make it work with the Debian package. Note how it uses env_vars to pass the parameters to the .service file: this is a consequence of #303 not overriding the .service file when using the Debian package, and might not work if the .service file is overriden.

[anarcat]

ping! i believe this can be merged: it passes tests and doesn't actually require #303...

it would be quite motivating for me to continue working on this module if i could get trivial stuff like this merged in. :)

[dhoppe]

Please provide also tests like:

• https://github.com/voxpupuli/puppet-prometheus/blob/master/spec/classes/apache_exporter_spec.rb

[dhoppe]

@anarcat The current tests are not failing, because we do not have any tests for the new exporter. Please add the missing tests and we are able to merge this pull requests.

[anarcat]

like in the bind exporter (#312), i've removed the debian-specific stuff from the YAML config, which belongs to the debian package (#303). To get it working right with the debian setup, the following is required:

prometheus::postfix_exporter::package_name: 'prometheus-postfix-exporter'
prometheus::postfix_exporter::service_name: 'prometheus-postfix-exporter'
prometheus::postfix_exporter::user: 'prometheus'
prometheus::postfix_exporter::group: 'prometheus'

[bastelfreak]

@anarcat can you please rebase and add a test for this?

[pccibot]

Dear @anarcat, thanks for the PR!

This is pccibot, your friendly Vox Pupuli GitHub Bot. I noticed that your pull request contains merge conflict. Can you please rebase?

You can find my sourcecode at voxpupuli/vox-pupuli-tasks

[pccibot]

Dear @anarcat, thanks for the PR!

This is pccibot, your friendly Vox Pupuli GitHub Bot. I noticed that your pull request contains merge conflict. Can you please rebase?

You can find my sourcecode at voxpupuli/vox-pupuli-tasks

[anarcat]

superseded by #396 thanks @alexjfisher !!!