revert the env_vars removal for two exporters #528
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We need the env_vars for the Debian package to work properly. In Debian-land, the systemd `.service` file gets its parameters from the EnvironmentFile, which we deploy through the `env_vars` here. Yes, it's backwards, and no, it's not great because it doesn't actually use the `options` stuff, but at least it works. This is necessary to have those exporters be able to accept options when using init_style=none and install_method=package. This is a split off of voxpupuli#303 which should at least pass tests (/probably/ because the `install_method=package` code path is basically untested).
This was referenced Feb 23, 2021
Closed
|
a cleaner approach for this is #530 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need the env_vars for the Debian package to work properly. In
Debian-land, the systemd
.servicefile gets its parameters from theEnvironmentFile, which we deploy through the
env_varshere.Yes, it's backwards, and no, it's not great because it doesn't
actually use the
optionsstuff, but at least it works.This is necessary to have those exporters be able to accept options
when using init_style=none and install_method=package.
This is a split off of #303 which should at least pass
tests (/probably/ because the
install_method=packagecode path isbasically untested).
See also #32