check node exporter config file instead of bird in node exporter test #531
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For some reason, the node exporter unit test checks for the inexistence of the bird_exporter config file. Naturally, it doesn't find it (why would it?). I suspect this is an artifact of a copy-paste from the bird exporter, and what was really meant here was to check for the inexistence of the node exporter config file.
anarcat
added a commit
to anarcat/puppet-prometheus
that referenced
this pull request
Feb 24, 2021
this is necessary now that voxpupuli#531 has been merged in
|
nice. thanks for fixing my copy and paste fuckup! |
cegeka-jenkins
pushed a commit
to cegeka/puppet-prometheus
that referenced
this pull request
Mar 11, 2024
this is necessary now that voxpupuli#531 has been merged in
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some reason, the node exporter unit test checks for the
inexistence of the bird_exporter config file. Naturally, it doesn't
find it (why would it?).
I suspect this is an artifact of a copy-paste from the bird exporter,
and what was really meant here was to check for the inexistence of the
node exporter config file.
I found this after getting a test failure #530. I couldn't understand why I wasn't getting the same error in the node exporter. Now I know.
Hopefully this is a noop.