Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changed rabbitmq_queue regex #782

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Changed rabbitmq_queue regex #782

wants to merge 1 commit into from

Conversation

GeorgeCox
Copy link

Pull Request (PR) description

Changed regex for rabbitmq_queue parameter.
Queues and vhosts are able to have spaces in their names, so the regex is to restrictive.

wyardley
wyardley reviewed Mar 25, 2019
View reviewed changes
Copy link
Contributor

@wyardley wyardley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi - thanks for the contribution.

Are there any considerations for special characters or other things that might cause an error when actually applied via Puppet? Can unit and / or integration tests be added to validate adding queues with spaces in the name?

@juniorsysadmin juniorsysadmin added the enhancement New feature or request label Mar 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wyardley wyardley wyardley left review comments

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@GeorgeCox @wyardley @juniorsysadmin