Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Palette 再考 #912

Closed
wants to merge 7 commits into from
Closed

WIP: Palette 再考 #912

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
1023be7
init
takurinton Jul 26, 2022
2dd6704
Merge branch 'master' into proposal/theme-palette
takurinton Aug 1, 2022
94418a6
add: disabled of background
takurinton Aug 7, 2022
60efe22
...
takurinton Aug 15, 2022
600ebb8
Merge branch 'master' into proposal/theme-palette
takurinton Aug 21, 2022
1aed078
remove: border property
takurinton Aug 23, 2022
1031d17
...
takurinton Aug 24, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 5 additions & 16 deletions src/themes/palette.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,11 +38,7 @@ export type PaletteAction = {
active: string;
hover: string;
selected: string;
selectedOpacity: number;
focus: string;
focusOpacity: number;
activeBackground: string;
hoverBackground: string;
disabled: string;
};

export type Palette = {
Expand Down Expand Up @@ -131,18 +127,11 @@ export const palette: Palette = {
fill: colors.basic[700],
line: colors.basic[600],
},

// opacity は全部 0.08 にする、
// WIP: 適当な候補だけ書いた
action: {
active: "rgba(0, 0, 0, 0.54)",
hover: "#F5F7F8", // basic[100]
selected: "rgba(0, 0, 0, 0.08)",
selectedOpacity: 0.08,
focus: "rgba(0, 0, 0, 0.12)",
focusOpacity: 0.08,
activeBackground: colors.basic[300],
hoverBackground: colors.basic[200],
active: colors.blue[50] as string,
hover: "",
selected: "",
disabled: colors.basic[200],
Comment on lines +131 to +134
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wip だけどこんな感じ
opacity とかは primary.main からいい感じに色を導くためのもので、今のうちの形だと不要なので消した。
とはいえ、これだけだと不十分でもう少し根本的な見直しが必要になりそう。ちょっと厳しさが見えてきた。

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hover, selected は後で定義

},
};

Expand Down