Feature. Add to cart popup #113
Conversation
|
Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖 Please select which version do you want to release:
And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.
|
LuisMendap
requested review from
icazevedo,
igorbrasileiro,
Gmantiqueira and
ricardoaerobr
and removed request for
a team
|
Beep boop 🤖 Thank you so much for keeping our documentation up-to-date ❤️ |
LuisMendap
force-pushed
the
feature/addToCartPopup
branch
from
b9d4211 to
6800844
Compare
|
Issue: #116 |
@LuisMendap , do you think the translations will still be necessary? Our translation workflow works on top of the English version, so when it is updated our translation management system requests the other translations automatically. |
|
Hi @sheilagomes, sorry, i dont understand very well, you want to say that the translations for other languages are not necessary in this case? This apply for all Vtex Apps? |
As far as I know, the VTEX structure demands you have at least the files for the three basic languages, English, Spanish and Portuguese, but you don't need to translate them. You can create only the messages in English and the Portuguese and Spanish files can have their values empty or simply be duplicated from English. But in this case, you have to let us know (mark Localization as reviewer if Github doesn't do it automatically) so we can guarantee the translation of the other languages will be taken care of as soon as possible. This will ensure the translations will be correct and fit the purposes intended for the app. |
LuisMendap
force-pushed
the
feature/addToCartPopup
branch
from
6800844 to
b75bb7c
Compare
LuisMendap
force-pushed
the
feature/addToCartPopup
branch
from
b75bb7c to
5d3de43
Compare
|
Thanks @sheilagomes I have already updated a new commit with all changes in translations files for revision. I kept the translations in English, Portuguese, and Spanish. |
Co-authored-by: Sheila Gomes <[email protected]>
What problem is this solving?
Add a new prop called 'popup' on add to cart button that show a modal when an item is added to cart
How to test it?
Workspace
Screenshots or example usage:
How does this PR make you feel? 🔗