Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add additional check to admin token #134

Merged
merged 5 commits into from
Apr 19, 2024
Merged

fix: add additional check to admin token #134

merged 5 commits into from
Apr 19, 2024

Conversation

enzomerca
Copy link
Contributor

@enzomerca enzomerca commented Apr 19, 2024 •
edited by jira bot
Loading

What problem is this solving?

Fix auth issue. See B2BTEAM-1633 for more info.

@vtex-io-ci-cd VTEX IO CI/CD
Copy link

vtex-io-ci-cd bot commented Apr 19, 2024 •
edited by enzomerca
Loading

Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖

Please select which version do you want to release:

  • Patch (backwards-compatible bug fixes)

  • Minor (backwards-compatible functionality)

  • Major (incompatible API changes)

And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.

  • No thanks, I would rather do it manually 😞

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 19, 2024 •
edited
Loading

Messages
📖 ❤️ Thanks!
📖

🎉 PR additions = 24, PR deletions = 2

Generated by 🚫 dangerJS against aff62b9

@enzomerca enzomerca marked this pull request as ready for review April 19, 2024 15:12
@enzomerca enzomerca requested a review from Rudge April 19, 2024 15:12
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@enzomerca enzomerca merged commit 91233a7 into master Apr 19, 2024
13 checks passed
@enzomerca enzomerca deleted the fix/B2BTEAM-1633-security-issue branch April 19, 2024 15:34
@vtex-io-ci-cd VTEX IO CI/CD
Copy link

vtex-io-ci-cd bot commented Apr 19, 2024

Your PR has been merged! App is being published. 🚀
Version 1.40.1 → 1.40.2

After the publishing process has been completed (check #vtex-io-releases) and doing A/B tests with the new version, you can deploy your release by running:

vtex deploy [email protected]

After that your app will be updated on all accounts.

For more information on the deployment process check the docs. 📖

enzomerca added a commit that referenced this pull request Apr 24, 2024
@enzomerca
Revert "fix: add additional check to admin token (#134)"
dc0c389 
This reverts commit 91233a7.
enzomerca added a commit that referenced this pull request Apr 24, 2024
@enzomerca
Revert auth changes due to rollback (#136)
61c8cbc 
* Revert "fix: provide correct tokens to clients (#135)"

This reverts commit 533a16e.

* Revert "fix: add additional check to admin token (#134)"

This reverts commit 91233a7.

* Revert "fix: add role check on checkUserAccess (#133)"

This reverts commit b4be44f.

* update: changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rudge Rudge Rudge approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@enzomerca @Rudge