Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: provide correct tokens to clients #135

Merged
merged 2 commits into from
Apr 24, 2024

Conversation

enzomerca
Copy link
Contributor

@enzomerca enzomerca commented Apr 23, 2024

What problem is this solving?

Provide correct tokens to clients. More info: https://vtex-dev.atlassian.net/browse/B2BTEAM-1633

This is a follow-up PR to the previous security issue PR.

Copy link

vtex-io-ci-cd bot commented Apr 23, 2024

Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖

Please select which version do you want to release:

  • Patch (backwards-compatible bug fixes)

  • Minor (backwards-compatible functionality)

  • Major (incompatible API changes)

And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.

  • No thanks, I would rather do it manually 😞

@vtex-io-docs-bot
Copy link

vtex-io-docs-bot bot commented Apr 23, 2024

Beep boop 🤖

I noticed you didn't make any changes at the docs/ folder

  • There's nothing new to document 🤔
  • I'll do it later 😞

In order to keep track, I'll create an issue if you decide now is not a good time

  • I just updated 🎉🎉

Copy link

github-actions bot commented Apr 23, 2024

Messages
📖 ❤️ Thanks!
📖

🎉 PR additions = 13, PR deletions = 5

Generated by 🚫 dangerJS against f45a35f

@enzomerca enzomerca marked this pull request as ready for review April 23, 2024 20:14
@enzomerca enzomerca requested a review from Rudge April 23, 2024 20:14
Copy link

@enzomerca enzomerca merged commit 533a16e into master Apr 24, 2024
23 checks passed
@enzomerca enzomerca deleted the fix/B2BTEAM-1633-provide-correct-tokens branch April 24, 2024 02:22
Copy link

vtex-io-ci-cd bot commented Apr 24, 2024

Your PR has been merged! App is being published. 🚀
Version 1.40.2 → 1.40.3

After the publishing process has been completed (check #vtex-io-releases) and doing A/B tests with the new version, you can deploy your release by running:

vtex deploy [email protected]

After that your app will be updated on all accounts.

For more information on the deployment process check the docs. 📖

enzomerca added a commit that referenced this pull request Apr 24, 2024
enzomerca added a commit that referenced this pull request Apr 24, 2024
* Revert "fix: provide correct tokens to clients (#135)"

This reverts commit 533a16e.

* Revert "fix: add additional check to admin token (#134)"

This reverts commit 91233a7.

* Revert "fix: add role check on checkUserAccess (#133)"

This reverts commit b4be44f.

* update: changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants