feat: Filter with next/dynamic
#638
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
eduardoformiga
added a commit
to vtex/faststore
that referenced
this pull request
Dec 18, 2024
## What's the purpose of this pull request? This PR involves significant changes to the filter components within the `ProductGallery` and related files. The main goal is to refactor the filter functionality by removing the `Filter` component and replacing it with `FilterDesktop` and `FilterSlider` components. Additionally, dynamic imports are introduced to optimize loading. Key changes include: Refactoring Filter Components: * Removed the `Filter` component and its associated code from `Filter.tsx`. * Updated `FilterDesktop.tsx` to include the GraphQL fragment previously in `Filter.tsx`. * Added dynamic imports for `Filter`, `FilterFacetBoolean`, `FilterFacetBooleanItem`, `FilterFacetRange`, `FilterFacets`, and `FilterSlider` in `FilterSlider.tsx`. * Modified `index.ts` to export `FilterDesktop` and `FilterSlider` instead of the removed `Filter` component. Dynamic Imports: * Replaced static imports with dynamic imports for `ProductCard`, `EmptyGallery`, `FilterDesktop`, and `FilterSlider` in `DefaultComponents.ts`. ## How to test it? You can use the preview URL from the starter PR and double check that some JS are just loaded after Open the Filter in the mobile version. https://sfj-d705510--starter.preview.vtex.app/office https://github.com/user-attachments/assets/b830ad60-9496-4fe2-b2c4-2837bfc8b364 ### Starters Deploy Preview - vtex-sites/starter.store#638
|
closing this PR because the changes has already been added. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the purpose of this pull request?
This PR applies changes from
Filterwith next/dynamic and lazy import vtex/faststore#2596Faststore related PRs
Filterwith next/dynamic and lazy import vtex/faststore#2596