enable unstructured cache #19
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cezar-guimaraes
force-pushed
the
feat/enable-unstructured-cache
branch
from
8d2dd05 to
af1aeaa
Compare
cezar-guimaraes
force-pushed
the
feat/enable-unstructured-cache
branch
from
af1aeaa to
bcf0fe5
Compare
added 2 commits
September 18, 2024 14:10
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By enabling the informer cache for unstructured objects, reconciling around 2000 cTTLs object took 2~3 minutes instead of 10~11 minutes.
The memory limit needed to be increased a bit to avoid getting OOM. During startup it hit a peak of 230MB before GC kicked in and stabilized usage at around 157MB
The informer cache, however, does not recognize lower case name for kinds, so we need to update our cTTLs to use the correctly cased name:
revision->Revision,service->Service.This draft implementation contains a hack to convert the 1st letter to upper case. It's unclear if updating some dependencies might fix this issue.
Usage of cache should also be locked behind a CLI bool flag.