Skip to content

Commit

Permalink
chore: remove copying faststore config during build (#2074)
Browse files Browse the repository at this point in the history
## What's the purpose of this pull request?

The faststore.config.js file from the `.faststore` folder was being
copied to the starter after the build, which caused it to throw errors
because it couldn't find default definitions for the config or the
copied starter config present inside `.faststore`.

Lighthouse was not working because of this.

## How it works?

This PR makes the CLI not copy the `.faststore/faststore.config.js` file
to the starter after the build.

## How to test it?

Run `yarn build` on the starter. You shouldn't see any changes in the
starter's `faststore.config.js` file.

### Starters Deploy Preview

vtex-sites/starter.store#232

The integration tests are failing due to an unsupported workflow on
webops. Lighthouse actually started working after this change!
  • Loading branch information
Ícaro Azevedo authored Oct 24, 2023
1 parent 6f1cc20 commit 2f46bc2
Showing 1 changed file with 0 additions and 4 deletions.
4 changes: 0 additions & 4 deletions packages/cli/src/commands/build.ts
Original file line number Diff line number Diff line change
Expand Up @@ -21,10 +21,6 @@ export default class Build extends Command {
}

await copyResource(`${tmpDir}/.next`, `${userDir}/.next`)
await copyResource(
`${tmpDir}/faststore.config.js`,
`${userDir}/faststore.config.js`
)
await copyResource(`${tmpDir}/public`, `${userDir}/public`)
await copyResource(
`${tmpDir}/lighthouserc.js`,
Expand Down

0 comments on commit 2f46bc2

Please sign in to comment.