Chore: Carousel items per page from cms #2062
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
eduardoformiga
changed the base branch from
main
to
chore/rename-first-shelf-fs-1287
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 152a4ac:
|
hellofanny
reviewed
Oct 13, 2023
hellofanny
requested review from
gvc and
Gmantiqueira
and removed request for
a team
hellofanny
force-pushed
the
chore/carousel-items-per-page-cms
branch
from
62fea59 to
f9ef873
Compare
eduardoformiga
commented
Nov 29, 2023
1 task
|
I can't approve this PR because I am the original author, but it's approved! hahaha |
hellofanny
approved these changes
Dec 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the purpose of this pull request?
Adds
itemsPerPagefield for Carousel in the ProductShelf section.How it works?
You should be able to set the carousel's itemsPerPage prop via CMS.
How to test it?
yarn devto run locallyhttp://localhost:3000/api/preview?contentType=home&documentId=509f861b-719d-11ee-83ab-0a650ce03a3d&versionId=52f602cb-719d-11ee-83ab-126d1b33ed09
Check in the CMS:
You should be able to see the
itemsPerPagefieldStarters Deploy Preview
vtex-sites/starter.store#291