fix: get first available item (sku) instead of first item (sku)

[eduardoformiga]

What's the purpose of this pull request?

This PR aims to get first available item (sku) instead of first item (sku) in products and suggestions queries.

Reference in v1: #1834

Address this issue

• PLP search result is incorrect if there's no price on the SKU rendered  #2132

How it works?

While in search Page and PLP, FastStore API products/suggestions search query was getting always the first item (sku) from the product.items. In this case, we should get the first available item.

Before	After

How to test it?

Check the preview link from starters store, with the tests mentioned in the issue.

Starters Deploy Preview

PR

• fix: get first available item (sku) instead of first item (sku) vtex-sites/starter.store#295

Preview

• https://sfj-41c253b--starter.preview.vtex.app/s?q=apple+magic&sort=score_desc&page=0

References

https://storeframework.myvtex.com/api/io/_v/api/intelligent-search/product_search/trade-policy/1/?hideUnavailableItems=true&q=Apple%20Magic%20Mouse

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
faststore-site	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Dec 4, 2023 8:33pm

[codesandbox-ci]

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 2964077:

Sandbox	Source
Store UI Typescript	Configuration

[icazevedo]

I just realized one thing: if a product has no available SKUs but matches the search query, previously, it would return as an Out Of Stock item.

The proposed logic would make it not appear at the search page in those cases.

I think for us to match the same behavior and fix the issue, we should make something like the suggestion below. I think we have to change this in v1 as well.

Suggested change

	const maybeSku = product.items.find((item) =>
	item.sellers.some((item) => inStock(item.commertialOffer))
	)
	const maybeSku = product.items.find((item) =>
	item.sellers.some((item) => inStock(item.commertialOffer))
	) ?? product.items[0]

[eduardoformiga]

Good catch. we kind of do that in the product query, but it is missing for products and suggestions.

Done here

[eduardoformiga]

after some discussion with the team, we understand that

• fix: pickBestSku instead of first sku in products query #2136
  fits the best approach.