feat: Add New Icons #2288
Open
feat: Add New Icons #2288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
renatamottam
force-pushed
the
feat/new-icons
branch
from
cd45a1c to
36f4de9
Compare
renatamottam
force-pushed
the
feat/new-icons
branch
from
9d99e4e to
8ecd18e
Compare
hellofanny
reviewed
Jan 16, 2025
| .replace(/\/([^\/]*)\//, '/$1-')}` | ||
| ) | ||
| } | ||
| // const { pathname } = new URL(request.url) |
There was a problem hiding this comment.
🎗️ TODO: uncomment this part when merging.
renatamottam
requested review from
eduardoformiga and
lucasfp13
and removed request for
a team
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the purpose of this pull request?
This PR updates our icon library to fit the new VTEX Design Foundation.
Activities
FS Corestore icons chore: Replace icons props #2292Extra: removed duplicated icons for the new version (the duplicates remain on the deprecated icons)-
Ellipsis→ fs-dots-three-
CircleWavyCheck→ fs-seal-check-
CircleWavyWarning→ fs-seal-warningNext Steps (to be done on other PRs)
RatingcomponentFor the Future
How it works?
For now, we're going to accept both symbol styles, but all new symbols added by us will be following the new pattern and the old will be deprecated eventually. Some important changes on the
Iconcomponent:sizeprop24height,widthandweightprops are now marked as deprecated (but it's still working)How to test it?
old docis updated for testing and reviewing purposes: https://faststore-site-e2u5eo3a7-vtex.vercel.app/docs/iconsStarter Storewith all the changes: https://brandless-cm673tum200ry3hb2qp48ho4e-a2eodssed.b.vtex.app/