fix: removes useUI() dependents sections from LazyLoadingSection
#2602
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
eduardoformiga
changed the title
useUI() dependents sections from LazyLoadingSection
lariciamota
reviewed
Dec 19, 2024
|
@eduardoformiga . Some js files are loaded when I open the cart sidebar. is it normal? Example: |
yes, that's because some internal components are being loaded dynamically. |
hellofanny
approved these changes
Dec 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the purpose of this pull request?
This removes the logic that dynamically loads the sections that depend on the
useUI()hook:CartSidebarandRegionModal. We decided to try to load them at another moment (//TODO: create a task for it) instead of on click.How to test it?
Try to load the respective sections
CartSidebarandRegionModalusing the preview link.You can see that both sections are being loaded in the initial loading now. Instead of loading after clicking on the respective buttons that trigger the sections.
Starters Deploy Preview