Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add deps and deps-dev scopes to PR title validation #2605

Merged
merged 2 commits into from
Dec 20, 2024

Conversation

lariciamota
Copy link
Contributor

@lariciamota lariciamota commented Dec 20, 2024

What's the purpose of this pull request?

Add the deps and deps-dev scopes to the PR title validation, so it can be used on the dependabot PRs that updates the deps versions.

How it works?

Adding this new scope this type of error won't happen on dependabot PRs:
Screenshot 2024-12-20 at 11 19 02

The deps-dev scope is for updates on devDependencies.

References

@lariciamota lariciamota self-assigned this Dec 20, 2024
@lariciamota lariciamota requested a review from a team as a code owner December 20, 2024 14:19
@lariciamota lariciamota requested review from renatamottam and renatomaurovtex and removed request for a team December 20, 2024 14:19
Copy link

vercel bot commented Dec 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Updated (UTC)
faststore-site ⬜️ Ignored (Inspect) Visit Preview Dec 20, 2024 2:44pm

Copy link

codesandbox-ci bot commented Dec 20, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@lariciamota lariciamota changed the title chore: add deps scope to PR title validation chore: add deps and deps-dev scopes to PR title validation Dec 20, 2024
@lariciamota lariciamota merged commit d877574 into main Dec 20, 2024
10 checks passed
@lariciamota lariciamota deleted the chore/add-PR-scope branch December 20, 2024 15:00
eduardoformiga pushed a commit that referenced this pull request Jan 15, 2025
## What's the purpose of this pull request?

Add the `deps` and `deps-dev` scopes to the PR title validation, so it
can be used on the dependabot PRs that updates the deps versions.

## How it works?

Adding this new scope
[this](https://github.com/vtex/faststore/actions/runs/12278625904/job/34260726276?pr=2589)
type of error won't happen on dependabot PRs:
![Screenshot 2024-12-20 at 11 19
02](https://github.com/user-attachments/assets/86d39ff7-9be9-42b7-a486-70feb79e2d3b)

The `deps-dev` scope is for updates on devDependencies.

## References

- #2580
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants