Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add starter integration test to ci #2660

Merged
merged 2 commits into from
Jan 31, 2025

Conversation

matheusps
Copy link
Contributor

@matheusps matheusps commented Jan 31, 2025

What's the purpose of this pull request?

For every pull request we do on faststore we must test the package against the starter. This is time consuming, and non error-prone since the local setup of each developer can vary.

The test runs on ci, and:

  1. build the packages
  2. generate a tarball for them with npm pack
  3. clone the starter
  4. install the packaged packages
  5. run build

@matheusps matheusps self-assigned this Jan 31, 2025
@matheusps matheusps requested a review from a team as a code owner January 31, 2025 15:07
@matheusps matheusps requested review from renatamottam and renatomaurovtex and removed request for a team January 31, 2025 15:07
Copy link

vercel bot commented Jan 31, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Updated (UTC)
faststore-site ⬜️ Ignored (Inspect) Visit Preview Jan 31, 2025 3:18pm

Copy link

codesandbox-ci bot commented Jan 31, 2025

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Copy link
Member

@eduardoformiga eduardoformiga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

niceee!

Copy link
Contributor

@lucasfp13 lucasfp13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

.github/workflows/ci.yml Show resolved Hide resolved
@matheusps matheusps merged commit a5c69a3 into main Jan 31, 2025
9 checks passed
@matheusps matheusps deleted the chore/starter-integration-test branch January 31, 2025 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants