Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version 4.x - Migration to v3 #95

Merged
merged 11 commits into from
Jun 9, 2020
Merged

Version 4.x - Migration to v3 #95

merged 11 commits into from
Jun 9, 2020

Conversation

salesfelipe
Copy link
Contributor

@salesfelipe salesfelipe commented May 29, 2020

What does this PR do? *

  • Using the new Subscriptions V3.

How to test it? *

Related to / Depends on *

https://github.com/vtex/subscriptions-graphql/pull/63

@salesfelipe salesfelipe added the enhancement New feature or request label May 29, 2020
@salesfelipe salesfelipe requested a review from a team as a code owner May 29, 2020 12:43
@salesfelipe salesfelipe requested a review from a team May 29, 2020 12:43
@salesfelipe salesfelipe self-assigned this May 29, 2020
@salesfelipe salesfelipe requested review from kaisermann and removed request for a team May 29, 2020 12:43
@vtex-io-ci-cd
Copy link

vtex-io-ci-cd bot commented May 29, 2020

Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖

Please select which version do you want to release:

  • Patch

  • Minor

  • Major

And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.

  • No thanks, I would rather do it manually 😞

@salesfelipe salesfelipe requested review from kevinch and removed request for a team May 29, 2020 12:43
@salesfelipe salesfelipe changed the title Migration V3 Version 4.x May 29, 2020
@salesfelipe salesfelipe changed the title Version 4.x Version 4.x - Migration to v3 May 29, 2020
@salesfelipe salesfelipe requested a review from kevinch June 1, 2020 14:32
@salesfelipe salesfelipe force-pushed the feature/migrationV3 branch from 7862a83 to 2219e93 Compare June 1, 2020 17:48
@salesfelipe salesfelipe force-pushed the feature/migrationV3 branch from 44e2dd8 to f445a41 Compare June 3, 2020 21:49
@salesfelipe salesfelipe changed the base branch from 1.x to 4.x June 8, 2020 13:24
@salesfelipe salesfelipe force-pushed the feature/migrationV3 branch from 045d120 to 4dc9ccb Compare June 8, 2020 13:32
@salesfelipe salesfelipe force-pushed the feature/migrationV3 branch from 68f874e to 5233190 Compare June 8, 2020 13:38
@@ -1,7 +1,7 @@
{
"vendor": "vtex",
"name": "my-subscriptions",
"version": "1.14.2",
"version": "3.14.2",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@salesfelipe why not bumping to 2.x here? Is it already in use?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, the portal version(current 0.x) will become the 2.x and the storev2 version(currently 1.x) will be the 4.x

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay. Guess that will be written down in the readme right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now it will :harold_pain:

@salesfelipe salesfelipe requested a review from kevinch June 8, 2020 23:57
@salesfelipe salesfelipe merged commit bb4cf5d into 4.x Jun 9, 2020
@salesfelipe salesfelipe deleted the feature/migrationV3 branch June 9, 2020 13:16
@vtex-io-ci-cd
Copy link

vtex-io-ci-cd bot commented Jun 9, 2020

Your PR has been merged! App is being published. 🚀
Version 3.14.2 → 4.0.0

After the publishing process has been completed (check #vtex-io-releases) and doing A/B tests with the new version, you can deploy your release by running:

vtex deploy [email protected]

After that your app will be updated on all accounts.

For more information on the deployment process check the docs. 📖

This was referenced Jun 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants