Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EDU-10347 23H2KR5 Policies System API #1047

Merged
merged 46 commits into from
Dec 1, 2023
Merged

EDU-10347 23H2KR5 Policies System API #1047

merged 46 commits into from
Dec 1, 2023

Conversation

karenkrieger
Copy link
Contributor

Types of changes

  • New content (endpoints, descriptions or fields from scratch)
  • Improvement (make an endpoint's title or description even better)
  • Spelling and grammar accuracy (self-explanatory)

@karenkrieger karenkrieger self-assigned this Nov 13, 2023
@github-actions GitHub Actions
Copy link

Thanks for your contribution. The .json file will be checked now with Spectral.

julia-rabello
julia-rabello requested changes Nov 13, 2023
View reviewed changes
VTEX - Policies System API.json Outdated Show resolved Hide resolved
VTEX - Policies System API.json Outdated Show resolved Hide resolved
VTEX - Policies System API.json Outdated Show resolved Hide resolved
VTEX - Policies System API.json Outdated Show resolved Hide resolved
VTEX - Policies System API.json Outdated Show resolved Hide resolved
VTEX - Policies System API.json Outdated Show resolved Hide resolved
VTEX - Policies System API.json Outdated Show resolved Hide resolved
VTEX - Policies System API.json Outdated Show resolved Hide resolved
VTEX - Policies System API.json Outdated Show resolved Hide resolved
VTEX - Policies System API.json Outdated Show resolved Hide resolved
karenkrieger and others added 12 commits November 13, 2023 14:19
@karenkrieger @julia-rabello
Update VTEX - Policies System API.json
e1272d1 
Co-authored-by: Júlia Rabello <[email protected]>
@karenkrieger @julia-rabello
Update VTEX - Policies System API.json
f6d882d 
Co-authored-by: Júlia Rabello <[email protected]>
@karenkrieger @julia-rabello
Update VTEX - Policies System API.json
4eb6467 
Co-authored-by: Júlia Rabello <[email protected]>
@karenkrieger @julia-rabello
Update VTEX - Policies System API.json
818f002 
Co-authored-by: Júlia Rabello <[email protected]>
@karenkrieger @julia-rabello
Update VTEX - Policies System API.json
0c86289 
Co-authored-by: Júlia Rabello <[email protected]>
@karenkrieger @julia-rabello
Update VTEX - Policies System API.json
473c339 
Co-authored-by: Júlia Rabello <[email protected]>
@karenkrieger @julia-rabello
Update VTEX - Policies System API.json
0373637 
Co-authored-by: Júlia Rabello <[email protected]>
@karenkrieger @julia-rabello
Update VTEX - Policies System API.json
ad436cf 
Co-authored-by: Júlia Rabello <[email protected]>
@karenkrieger @julia-rabello
Update VTEX - Policies System API.json
8e380bb 
Co-authored-by: Júlia Rabello <[email protected]>
@karenkrieger @julia-rabello
Update VTEX - Policies System API.json
e26857a 
Co-authored-by: Júlia Rabello <[email protected]>
@karenkrieger @julia-rabello
Update VTEX - Policies System API.json
c75cc89 
Co-authored-by: Júlia Rabello <[email protected]>
@karenkrieger
Merge branch 'master' into EDU-10347-23H2KR5-Policies-System-API
b736b0d
julia-rabello
julia-rabello requested changes Nov 13, 2023
View reviewed changes
Copy link
Contributor

@julia-rabello julia-rabello left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Além das sugestões, resolver os erros do Spectral.

VTEX - Policies System API.json Show resolved Hide resolved
julia-rabello
julia-rabello requested changes Nov 13, 2023
View reviewed changes
Copy link
Contributor

@julia-rabello julia-rabello left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Falta resolver os comentários do Spectral, além das sugestões

VTEX - Policies System API.json Show resolved Hide resolved
VTEX - Policies System API.json Show resolved Hide resolved
VTEX - Policies System API.json Show resolved Hide resolved
VTEX - Policies System API.json Show resolved Hide resolved
VTEX - Policies System API.json Show resolved Hide resolved
VTEX - Policies System API.json Show resolved Hide resolved
VTEX - Policies System API.json Show resolved Hide resolved
VTEX - Policies System API.json Show resolved Hide resolved
julia-rabello
julia-rabello requested changes Nov 14, 2023
View reviewed changes
VTEX - Policies System API.json Outdated Show resolved Hide resolved
VTEX - Policies System API.json Show resolved Hide resolved
VTEX - Policies System API.json Outdated Show resolved Hide resolved
VTEX - Policies System API.json Show resolved Hide resolved
VTEX - Policies System API.json Outdated Show resolved Hide resolved
VTEX - Policies System API.json Outdated Show resolved Hide resolved
VTEX - Policies System API.json Show resolved Hide resolved
VTEX - Policies System API.json Show resolved Hide resolved
VTEX - Policies System API.json Outdated Show resolved Hide resolved
VTEX - Policies System API.json Show resolved Hide resolved
julia-rabello
julia-rabello approved these changes Dec 1, 2023
View reviewed changes
Copy link
Contributor

@julia-rabello julia-rabello left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@karenkrieger karenkrieger merged commit ccf4252 into master Dec 1, 2023
@karenkrieger karenkrieger deleted the EDU-10347-23H2KR5-Policies-System-API branch December 1, 2023 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julia-rabello julia-rabello julia-rabello approved these changes

Assignees

@karenkrieger karenkrieger

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@karenkrieger @julia-rabello