Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EDU-13834 - Add new parameter and update descriptions #1381

Merged
merged 14 commits into from
Feb 6, 2025

Conversation

mariananantua
Copy link
Contributor

Types of changes

  • New content (endpoints, descriptions or fields from scratch)
  • Improvement (make an endpoint's title or description even better)
  • Spelling and grammar accuracy (self-explanatory)

Changelog

Do not forget to update your changes to our Developer Portal's changelog. Did you create a release note?

  • Yes, I already created a release note about this change.
  • No, but I am going to.

Copy link

github-actions bot commented Feb 4, 2025

Thanks for your contribution. The .json file will be checked now with Spectral.

Copy link
Contributor

@PedroAntunesCosta PedroAntunesCosta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I recommend addressing the spectral alerts. Especially because the permissions are already indicated in some of the endpoints, just not in the format we standardized. See our doc on Endpoint permissions.

VTEX - Orders API.json Show resolved Hide resolved
VTEX - Orders API.json Show resolved Hide resolved
VTEX - Orders API.json Show resolved Hide resolved
Copy link
Contributor

@PedroAntunesCosta PedroAntunesCosta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job! But you must update the branch and, possibly, address conflicts.

@mariananantua mariananantua merged commit 2104493 into master Feb 6, 2025
2 of 4 checks passed
@mariananantua mariananantua deleted the add-new-parameter-and-update-descriptions branch February 6, 2025 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants