Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ad network api: move servers definition to path level #1384

Merged
merged 2 commits into from
Feb 6, 2025

Conversation

julia-rabello
Copy link
Contributor

following these guidelines to move server definition path level and render the correct server for the sponsored products endpoint

Types of changes

  • New content (endpoints, descriptions or fields from scratch)
  • Improvement (make an endpoint's title or description even better)
  • Spelling and grammar accuracy (self-explanatory)

Changelog

Do not forget to update your changes to our Developer Portal's changelog. Did you create a release note?

  • Yes, I already created a release note about this change.
  • No, but I am going to.

@julia-rabello julia-rabello requested a review from a team February 6, 2025 12:35
@julia-rabello julia-rabello self-assigned this Feb 6, 2025
Copy link

github-actions bot commented Feb 6, 2025

Thanks for your contribution. The .json file will be checked now with Spectral.

Copy link
Contributor

@ricardoaerobr ricardoaerobr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@julia-rabello julia-rabello merged commit 2373696 into master Feb 6, 2025
1 check passed
@julia-rabello julia-rabello deleted the move-server-ad-network-api branch February 6, 2025 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants