Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(search): apply latest changes from design qa #1307

Merged
merged 3 commits into from
Nov 30, 2023
Merged

chore(search): apply latest changes from design qa #1307

merged 3 commits into from
Nov 30, 2023

Conversation

marcelovicentegc
Copy link
Member

@marcelovicentegc marcelovicentegc commented Nov 28, 2023 •
edited
Loading

Apply latest changes proposed at:

Resolves #1043

@marcelovicentegc marcelovicentegc requested a review from a team as a code owner November 28, 2023 19:07
@marcelovicentegc marcelovicentegc self-assigned this Nov 28, 2023
@vercel Vercel
Copy link

vercel bot commented Nov 28, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
shoreline-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 30, 2023 5:38pm

@marcelovicentegc marcelovicentegc mentioned this pull request Nov 28, 2023
Closed
@marcelovicentegc marcelovicentegc changed the title chore(search): apply latest changes from https://github.com/vtex/shoreline/issues/1043 chore(search): apply latest changes from #1043 Nov 28, 2023
@marcelovicentegc marcelovicentegc changed the title chore(search): apply latest changes from #1043 chore(search): apply latest changes from design qa Nov 28, 2023
matheusps
matheusps approved these changes Nov 30, 2023
View reviewed changes
Copy link
Contributor

@matheusps matheusps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This extra mergeRef import is giving you a build error

packages/components/src/search/search.tsx Outdated Show resolved Hide resolved
@marcelovicentegc marcelovicentegc merged commit 84853a8 into main Nov 30, 2023
4 checks passed
@marcelovicentegc marcelovicentegc deleted the qa/search branch November 30, 2023 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matheusps matheusps matheusps approved these changes

@beatrizmilhomem beatrizmilhomem beatrizmilhomem approved these changes

@davicostalf davicostalf Awaiting requested review from davicostalf

Assignees

@marcelovicentegc marcelovicentegc

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Search: Design QA
3 participants
@marcelovicentegc @matheusps @beatrizmilhomem