Skip to content

Commit

Permalink
Change 'full' size value from EXPERIMENTAL_Modal to 'fit-horizontally…
Browse files Browse the repository at this point in the history
…' instead
  • Loading branch information
estacioneto committed Apr 26, 2021
1 parent 006aa90 commit 8404085
Show file tree
Hide file tree
Showing 4 changed files with 6 additions and 6 deletions.
2 changes: 1 addition & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.

### Added

- **EXPERIMENTAL_Modal** `full` and `auto` sizes.
- **EXPERIMENTAL_Modal** `fit-horizontally` and `auto` sizes.

## [9.138.3] - 2021-04-20

Expand Down
6 changes: 3 additions & 3 deletions react/components/EXPERIMENTAL_Modal/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ The anatomy consists of an overlay to block user interaction below the Modal and
| responsiveFullScreen | `boolean` | 🚫 | false | If true the modal will expand to fullscreen in small view ports |
| showTopBar | `boolean` | 🚫 | true | If true, show top bar with title |
| onCloseTransitionFinish | `func` | 🚫 | | Event fired when the closing transition is finished |
| size | `enum` | 🚫 | medium | Modal Size. One of: "small", "medium", "large", "full" and "auto" |
| size | `enum` | 🚫 | medium | Modal Size. One of: "small", "medium", "large", "fit-horizontally" and "auto" |
| aria-label | `string` | 🚫 | | Acessible Modal name. If this name is visible on the screen, prefer to use aria-labelledby |
| aria-labelledby | `string` | 🚫 | `vtex-modal__title` | ID of the element that provides the Modal an accessible name. If aria-label and aria-albelledby is not defined, the default here will be the title element. |
| aria-describedby | `string` | 🚫 | | ID of the element that provides the Modal an accessible description |
Expand Down Expand Up @@ -430,7 +430,7 @@ const ModalExample = () => {
;<ModalExample />
```

##### Full
##### Fit Horizontally

```js
const Button = require('../Button').default
Expand All @@ -447,7 +447,7 @@ const ModalExample = () => {
<Modal
isOpen={isOpen}
onClose={onClose}
size="full"
size="fit-horizontally"
title="Import products by CSV"
aria-describedby="modal-description"
bottomBar={
Expand Down
2 changes: 1 addition & 1 deletion react/components/EXPERIMENTAL_Modal/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ export interface Props
showBottomBarBorder?: boolean
onCloseTransitionFinish?: () => unknown
centered?: boolean
size?: 'small' | 'medium' | 'large' | 'full' | 'auto'
size?: 'small' | 'medium' | 'large' | 'fit-horizontally' | 'auto'
responsiveFullScreen?: boolean
}

Expand Down
2 changes: 1 addition & 1 deletion react/components/EXPERIMENTAL_Modal/modal.stories.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ import useDisclosure from '../../utilities/useDisclosure'
import Button from '../Button'
import Input from '../Input'

const sizes = ['small', 'medium', 'large', 'full', 'auto']
const sizes = ['small', 'medium', 'large', 'fit-horizontally', 'auto']

export default {
title: 'Components/Modal V2',
Expand Down

0 comments on commit 8404085

Please sign in to comment.