Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#trivial : fix inputs eslint issues #1105

Merged
merged 5 commits into from
Mar 20, 2020
Merged

#trivial : fix inputs eslint issues #1105

merged 5 commits into from
Mar 20, 2020

Conversation

matheusps
Copy link
Contributor

@matheusps matheusps commented Mar 19, 2020 •
edited by emersonlaurentino
Loading

What is the purpose of this pull request?

eslint fixes for: Input, InputCurrency, InputPassword & InputSearch #1082

Types of changes

  • Bugfix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Requires change to documentation, which has been updated accordingly.

@matheusps matheusps requested review from thayannevls, emersonlaurentino and a team March 19, 2020 01:19
@matheusps matheusps requested a review from a team as a code owner March 19, 2020 01:19
@matheusps matheusps self-assigned this Mar 19, 2020
kevinch
kevinch previously approved these changes Mar 19, 2020
View reviewed changes
Klynger
Klynger previously approved these changes Mar 19, 2020
View reviewed changes
@emersonlaurentino emersonlaurentino mentioned this pull request Mar 19, 2020
Closed
74 tasks
emersonlaurentino
emersonlaurentino requested changes Mar 19, 2020
View reviewed changes
react/components/InputPassword/index.js Outdated Show resolved Hide resolved
react/components/InputSearch/index.js Outdated Show resolved Hide resolved
thayannevls
thayannevls previously approved these changes Mar 19, 2020
View reviewed changes
@matheusps matheusps dismissed stale reviews from thayannevls, Klynger, and kevinch via 578ff4a March 20, 2020 17:41
@matheusps matheusps merged commit f1ebcb3 into features Mar 20, 2020
@matheusps matheusps deleted the fix/eslint-inputs branch March 20, 2020 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Klynger Klynger Klynger left review comments

@lucasecdb lucasecdb lucasecdb approved these changes

@emersonlaurentino emersonlaurentino emersonlaurentino approved these changes

@kevinch kevinch kevinch left review comments

@thayannevls thayannevls thayannevls left review comments

Assignees

@matheusps matheusps

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@matheusps @kevinch @thayannevls @Klynger @lucasecdb @emersonlaurentino