Add Modal and ModalDialog Tests #1121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thayannevls
force-pushed
the
chore/modal-tests
branch
4 times, most recently
from
8b0c3af to
dd120af
Compare
thayannevls
requested review from
emersonlaurentino,
matheusps,
JRobsonJr,
igorbrasileiro and
lucasecdb
kevinch
requested changes
Mar 26, 2020
kevinch
previously approved these changes
Mar 26, 2020
thayannevls
commented
Mar 26, 2020
| > | ||
| Foo | ||
| </ModalDialog>, | ||
| { container: document.body } |
There was a problem hiding this comment.
I couldn't remove thedocument.body here because without it I can't find the button by the text, but I believe that when I rewrite the component I'll be able to capture by using test-id or something similar
kevinch
previously approved these changes
Mar 31, 2020
estacioneto
previously approved these changes
Mar 31, 2020
emersonlaurentino
previously approved these changes
Mar 31, 2020
thayannevls
dismissed stale reviews from emersonlaurentino, estacioneto, and kevinch
via
5e7827d
thayannevls
force-pushed
the
chore/modal-tests
branch
from
020e21d to
5e7827d
Compare
emersonlaurentino
approved these changes
Apr 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request?
#trivial: Add
ModalandModalDialogtests.Obs: Since Modal uses Portal, I had to change the container in all tests to work properly.
What problem is this solving?
#1083
How should this be manually tested?
yarn && yarn testTypes of changes