Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#trivial Disable tslint & eslint issues of useCheckboxTree #1223

Merged
merged 1 commit into from
May 29, 2020
Merged

#trivial Disable tslint & eslint issues of useCheckboxTree #1223

merged 1 commit into from
May 29, 2020

Conversation

matheusps
Copy link
Contributor

@matheusps matheusps commented May 28, 2020 •
edited
Loading

What is the purpose of this pull request?

Fix es/ts lint issues by skipping then. This is done because the component needs refactoring before leave experimental. (Huge fixes would be lost)

Related issue #1082

Types of changes

  • Bugfix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Requires change to documentation, which has been updated accordingly.

@matheusps matheusps requested review from emersonlaurentino, estacioneto and a team May 28, 2020 17:15
@matheusps matheusps requested a review from a team as a code owner May 28, 2020 17:15
@matheusps matheusps self-assigned this May 28, 2020
@vercel
Copy link

vercel bot commented May 28, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/styleguide-core/styleguide/3iu0c9ouc
✅ Preview: https://styleguide-git-fix-exp-use-checkbox-tree-lint.styleguide-core.now.sh

@emersonlaurentino emersonlaurentino mentioned this pull request May 28, 2020
Closed
74 tasks
@estacioneto estacioneto changed the title #trivial Disable tslint & eslint isses of useCheckboxTree #trivial Disable tslint & eslint issues of useCheckboxTree May 28, 2020
@matheusps matheusps merged commit b362dd5 into features May 29, 2020
@matheusps matheusps deleted the fix/exp-use-checkbox-tree-lint branch May 29, 2020 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emersonlaurentino emersonlaurentino emersonlaurentino approved these changes

@estacioneto estacioneto estacioneto approved these changes

Assignees

@matheusps matheusps

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@matheusps @emersonlaurentino @estacioneto