Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#trivial Fix exp table eslint issues #1224

Merged
merged 2 commits into from
Jun 19, 2020
Merged

#trivial Fix exp table eslint issues #1224

merged 2 commits into from
Jun 19, 2020

Conversation

matheusps
Copy link
Contributor

What is the purpose of this pull request?

As the title says. Related issue #1082

Types of changes

  • Bugfix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Requires change to documentation, which has been updated accordingly.

@matheusps matheusps self-assigned this May 28, 2020
@vercel
Copy link

vercel bot commented May 28, 2020 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/styleguide-core/styleguide/m4e2i39q8
✅ Preview: https://styleguide-git-fix-exp-table-lint.styleguide-core.vercel.app

@emersonlaurentino emersonlaurentino mentioned this pull request May 28, 2020
Closed
74 tasks
@matheusps matheusps marked this pull request as ready for review June 4, 2020 13:12
@matheusps matheusps requested a review from a team June 4, 2020 13:12
@matheusps matheusps requested a review from a team as a code owner June 4, 2020 13:12
estacioneto
estacioneto approved these changes Jun 8, 2020
View reviewed changes
react/components/EXPERIMENTAL_Table/Sections/Thead.tsx
onClick?: () => void
}
column: Column
key: string
suffix: ReactElement
suffix: ReactNode
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✨

@matheusps matheusps force-pushed the fix/exp-table-lint branch from 115686b to e385d57 Compare June 18, 2020 19:25
@matheusps matheusps force-pushed the fix/exp-table-lint branch from e385d57 to e6d5a61 Compare June 19, 2020 09:54
@matheusps matheusps merged commit d9aac9e into features Jun 19, 2020
@matheusps matheusps deleted the fix/exp-table-lint branch June 19, 2020 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@estacioneto estacioneto estacioneto approved these changes

@emersonlaurentino emersonlaurentino Awaiting requested review from emersonlaurentino

Assignees

@matheusps matheusps

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@matheusps @estacioneto