Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hamburguer menu sections #14

Merged
merged 35 commits into from
Jan 18, 2024
Merged

Hamburguer menu sections #14

merged 35 commits into from
Jan 18, 2024

Conversation

Pvcunha
Copy link
Contributor

@Pvcunha Pvcunha commented Jan 8, 2024 •
edited
Loading

Description

O menu hamburguer utilizava os mesmos componentes passados para a sidebar. Agora ele possui seu proprio conjunto de secoes.

  • Adicionado uma nova matriz de secoes como parametro
  • Mapeamento das secoes do hamburguer menu eh feito pela nova matriz.
  • Adiciona ID para o tipo Section, para que possam ser identificadas páginas de diferentes linguagens da sidebar
  • Corrige o erro do botão '>' para todos os links na sidebar quando é mobile, ficando apenas para as que correspondem a documentação.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Requires change to documentation, which has been updated accordingly. (still not updated)

@Pvcunha Pvcunha requested a review from aliceoq January 8, 2024 20:42
github-actions[bot]
github-actions bot requested changes Jan 8, 2024
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request does not contain a valid label. Please add one of the following labels: ['release-no', 'release-auto', 'release-patch', 'release-minor', 'release-major']

@Pvcunha Pvcunha added the release-major Major version bump label Jan 8, 2024
@Pvcunha Pvcunha requested review from brunoamui and RobsonOlv January 9, 2024 13:37
@Pvcunha Pvcunha marked this pull request as ready for review January 9, 2024 13:37
RobsonOlv
RobsonOlv approved these changes Jan 10, 2024
View reviewed changes
Copy link
Contributor

@RobsonOlv RobsonOlv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

carolinamenezes and others added 15 commits January 12, 2024 12:37
aliceoq
aliceoq approved these changes Jan 17, 2024
View reviewed changes
Copy link
Contributor

@aliceoq aliceoq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Pvcunha Pvcunha requested a review from RobsonOlv January 17, 2024 15:30
RobsonOlv
RobsonOlv approved these changes Jan 18, 2024
View reviewed changes
Copy link
Contributor

@RobsonOlv RobsonOlv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@Pvcunha Pvcunha merged commit b43c1ba into main Jan 18, 2024
1 check passed
@Pvcunha Pvcunha deleted the feat/hamburguerMenu-sections branch January 18, 2024 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] approved these changes

@RobsonOlv RobsonOlv RobsonOlv approved these changes

@aliceoq aliceoq aliceoq approved these changes

@brunoamui brunoamui Awaiting requested review from brunoamui

Assignees
No one assigned
Labels
release-major Major version bump
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Pvcunha @RobsonOlv @aliceoq @carolinamenezes