Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support SVG 2 elements, using @vue/shared to ensure consistent behavi… #745

Merged
merged 3 commits into from
Mar 3, 2025

Conversation

2234839
Copy link
Contributor

@2234839 2234839 commented Feb 26, 2025

🤔 What is the nature of this change?

  • New feature
  • Fix bug
  • Style optimization
  • Code style optimization
  • Performance optimization
  • Build optimization
  • Refactor code or style
  • Test related
  • Other

🔗 Related Issue :jsx behavior not consistent with vue template

Note the call to _resolveComponent in the

Vue SFC Playground - Example template

Vue SFC Playground - Example jsx

💡 Background or solution

I encountered the following warning during development, I found that it was due to the old svg-tags library (someone mentioned pr for svg 2 support to the repository but it wasn't accepted yet), I changed the code to be consistent with the behavior of vue to solve the problem.

[Vue warn]: Failed to resolve component: feDropShadow
If this is a native custom element, make sure to exclude it from component resolution via compilerOptions.isCustomElement.

📝 Changelog

Language Changelog
🇺🇸 English svg and html elements to use @vue/shared.
🇨🇳 Chinese svg 和 html 元素的判断改为使用 @vue/shared

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

Copy link

netlify bot commented Feb 26, 2025

Deploy Preview for vue-jsx-explorer ready!

Name Link
🔨 Latest commit d32e371
🔍 Latest deploy log https://app.netlify.com/sites/vue-jsx-explorer/deploys/67c0738c2825590007b267b0
😎 Deploy Preview https://deploy-preview-745--vue-jsx-explorer.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@2234839
Copy link
Contributor Author

2234839 commented Mar 2, 2025

@haoqunjiang Are there any issues with this PR yet, can it be merged?

@haoqunjiang
Copy link
Member

The PR is fine. I was just too busy the past weekend.

@haoqunjiang haoqunjiang merged commit a7607de into vuejs:main Mar 3, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants