Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(custom-element): fix parent, observer and exposed issues when remove element and append it back after fully unmounted #12413

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(custom-element): fix parent, observer and exposed issues when remove element and append it back after fully unmounted #12413

wants to merge 1 commit into from
+67 −13

Conversation

lejunyang
Copy link

close #12412

changes:

  • extract observer code
  • observe again and re-mount if it's resolved and no instance, new parent will be set on new mount
  • exposed properties should be configurable, and we should delete them if element is fully unmounted, so that we can expose again in new mount

fix(custom-element): fix parent, observer and exposed issues when rem…
0e913dc 
…ove element and append it back after fully unmounted (vuejs#12412)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove vue custom element and append it back later can cause a lot of issues
1 participant
@lejunyang