-
-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(history): Resolve the href in <base>
correctly (#3819)
#3823
base: dev
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for vue-router-docs-v3 canceled.
|
Thanks for the PR. Can you provide a failing test or boiled-down repro? Note a base should not contain a hash |
An example of reproduction can be found in #3819, and you can view the source code of the Reproduction link. Some browser extensions or proxies may modify This PR should implement support for almost all legal baseURIs. |
That base has a hash though. As I said, it cannot have a hash |
That reproduction link contains several mistakes at the same time:
Additional reproduction links: |
@posva |
* Resolve the href in `<base>` correctly. * In hash mode, the hash in base is automatically removed and the base trailing slash is distinguished. * By default the result of `router.resolve().href` is the same as the actual switched URL.
Resolve the href in
<base>
correctly.In hash mode, the hash in base is automatically removed and the base trailing slash is distinguished.
By default the result of
router.resolve().href
is the same as the actual switched URL.Relates to: #3819, #2865