Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Managed Kafka #337

Merged
merged 4 commits into from
Oct 17, 2024
Merged

Conversation

christhemorse
Copy link
Contributor

@christhemorse christhemorse commented Oct 17, 2024

Description

This PR adds support for the Kafka engine type under the Managed Database product umbrella. In addition, there are a couple of small changes to data types such as with PlanReplicas in the Database struct (since it's replaced by plan_brokers for Kafka) and MinValue and MaxValue under AvailableOption being converted from int to float. Those will have to be accounted for when updating the vultr-cli and terraform libraries. Also, I reordered the DatabaseAdvancedOptions struct so the PG ones are together first, followed by MySQL and Kafka, so we're not trying to alphabetize everything we add across all the engine types. Otherwise, there are just a number of new properties and endpoints to establish all the launch functionality of Managed Kafka.

Checklist:

  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you linted your code locally prior to submission?
  • Have you successfully ran tests with your changes locally?

@christhemorse christhemorse added the enhancement New feature or request label Oct 17, 2024
Copy link
Member

@optik-aper optik-aper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@optik-aper optik-aper merged commit c9c1cea into vultr:master Oct 17, 2024
6 checks passed
@christhemorse christhemorse deleted the database-support-kafka branch October 17, 2024 19:57
@optik-aper optik-aper mentioned this pull request Oct 22, 2024
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants