Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix edge dev detection, Add edge channel detection #81

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fix edge dev detection, Add edge channel detection #81

wants to merge 3 commits into from

Conversation

leumasme
Copy link

Closes #80

vweevers
vweevers requested changes Mar 31, 2023
View reviewed changes
Copy link
Owner

@vweevers vweevers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please address the test failures (code style nits).

@leumasme leumasme requested a review from vweevers March 31, 2023 20:20
@pimterry pimterry mentioned this pull request Apr 3, 2023
Open
@pimterry
Copy link
Contributor

Hi @vweevers, any thoughts on this? It looks like the linting issues have been fixed (the job just needs approval to run) and I'd love to see this merged so we can use it downstream.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vweevers vweevers Awaiting requested review from vweevers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Edge Dev is not found
3 participants
@leumasme @pimterry @vweevers