Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update DB implementations. #83

Merged
merged 3 commits into from
Nov 27, 2023
Merged

Update DB implementations. #83

merged 3 commits into from
Nov 27, 2023

Conversation

JSAssassin
Copy link
Contributor

@JSAssassin JSAssassin commented Nov 20, 2023

@BigBlueHat @aljones15 cc: @msporny Do we want to retain the issuers and verifiers associated with ecdsa-rdfc-2019, eddsa-rdfc-2022, vc2.0, and Ed25519Signature2020 for all implementers in this repository or should they be removed? The tests for those live in the w3c organization and the test suites there are using the vc-test-suite-implementation repository to get the implementers. Currently, the issuers/verifiers tagged with these labels here aren't being used.

@JSAssassin JSAssassin marked this pull request as ready for review November 20, 2023 14:49
implementations/DigitalBazaar.json Outdated Show resolved Hide resolved
@BigBlueHat
Copy link
Contributor

Currently, the issuers/verifiers tagged with these labels here aren't being used.

I think we should clarify which "implementations" cover which specs/tests via which tags. I'd remove any that are duplicated currently in those lists, and update the READMEs in each repo to state which tags are associated with which suite.

Essentially, now that some of these specs have moved into the W3C org, their tagged implementations should also "move" to the implementations repo there.

If that sounds right @JSAssassin @dlongley, I'm happy to do the cleanup.

Copy link
Contributor

@aljones15 aljones15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM I'm assuming this has all been tested.

@JSAssassin JSAssassin merged commit 7f2f89d into main Nov 27, 2023
2 checks passed
@JSAssassin JSAssassin deleted the update-db-implementations branch November 27, 2023 20:54
@JSAssassin
Copy link
Contributor Author

Currently, the issuers/verifiers tagged with these labels here aren't being used.

I think we should clarify which "implementations" cover which specs/tests via which tags. I'd remove any that are duplicated currently in those lists, and update the READMEs in each repo to state which tags are associated with which suite.

Essentially, now that some of these specs have moved into the W3C org, their tagged implementations should also "move" to the implementations repo there.

If that sounds right @JSAssassin @dlongley, I'm happy to do the cleanup.

@BigBlueHat Sorry, I forgot to reply to this. I think that sounds right. I've opened an issue for this here - #85

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants