-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add class
and id
mappings
#2308
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for wai-aria ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
class
and id
mappingsclass
and id
mappings
Removing myself as reviewer as I just wanted to review the code references. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The change looks good, but we should verify that all implementations match it -- not just chrome. @rahimabdi, I added you back as a review because in the WG meeting we asked you to review for webkit, if you don't mind :)
I'll look at firefox now.
Ok, I checked Firefox, and Firefox doesn't implement AXDOMClassList on, but otherwise is good. |
change `<code>` to just ` marks per (most) other instances
approving pending @rahimabdi's review to just verify the webkit mappings. once good on that, we can merge. |
class
and id
mappingsclass
and id
mappings
@smockle @spectranaut @scottaohara The WebKit mappings are correct: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
WebKit mappings are correct 👍🏾.
Closes w3c/html-aam#553
Initially filed as w3c/html-aam#559
@aleventhal provided mappings in w3c/html-aam#553. I verified they match up with Chromium’s mappings:
id
kHtmlId
maps toid
in ax_platform_node_base.cc;l=1506-1509kHtmlId
maps toUIA_AutomationIdPropertyId
in ax_platform_node_win.cc;l=5254-5264 (viaGetAuthorUniqueId()
)kHtmlId
maps toAXDOMIdentifier
in ax_platform_node_cocoa.mm;l=1594-1601class
kClassName
maps toclass
in ax_platform_node_base.cc;l=1492-1497kClassName
maps toUIA_ClassNamePropertyId
in ax_platform_node_win.cc;l=5265-5269kClassName
maps toAXDOMClassList
in ax_platform_node_cocoa.mm;l=1577-1592Reviewers: Please also check the formatting. I’ve attempted to match existing styles, but those are inconsistent, e.g. “Object attributes” is bold in datetime (but not in draggable); it uses
<code>
in src (but not in abbr).Previews
class
id
❧
Test, Documentation and Implementation tracking
Once this PR has been reviewed and has consensus from the working group, tests should be written and issues should be opened on browsers. Add N/A and check when not applicable.