Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(closes #555) Fall back to default logic in useNativeTypes mode for RDF numbers which are not JSON numbers #625

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

anatoly-scherbakov
Copy link

@anatoly-scherbakov anatoly-scherbakov commented Jan 12, 2025

This is my second attempt to fix this issue after #619.


Preview | Diff

Copy link
Member

@gkellogg gkellogg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor changes, but this direction seems like the way to go.

index.html Show resolved Hide resolved
index.html Show resolved Hide resolved
@anatoly-scherbakov anatoly-scherbakov force-pushed the 555-blind-spot-in-rdf-to-object-conversion branch from fd7684b to 3b61a1b Compare January 13, 2025 19:52
index.html Outdated Show resolved Hide resolved
@BigBlueHat BigBlueHat added the class-3 Class-3 change label Jan 15, 2025
@anatoly-scherbakov
Copy link
Author

  • Todo: implement <ins> & <del> tags

@w3cbot
Copy link

w3cbot commented Jan 15, 2025

This was discussed during the #json-ld meeting on 15 January 2025.

View the transcript

w3c/json-ld-api#625

anatoly-scherbakov: this is the new version of w3c/json-ld-api#619 ; thanks gkellogg and pchampin for your suggestions.

gkellogg: it's a fairly small change.
… However, it is not purely editorial, so it should be turned into a candidate amendment, with <ins>s, <del>s...
… It has to be done manually, not much automation is available for that.

anatoly-scherbakov: I can not wrap a whole block in <ins> or <del>, right?

bigbluehat: correct, they are 'inline'. Is there a specific class to use?

gkellogg: there are other things to put in place. Respec documentation for them is not great, but there are examples in the same doc.

anatoly-scherbakov: what is the use-case for this marking?

gkellogg: it is there for reviewers of the specification, because we are editing a published Recommendation.

anatoly-scherbakov: an HTML diff will not be enough for the reviewers?

gkellogg: no, they do not expect to look at HTML raw code.
… You can look at the W3C process documents that describes the requirements for these things.

<gkellogg> https://www.w3.org/policies/process/#candidate-amendments

bigbluehat: this is required until we recharter. The alternative is to keep a bunch of open PR and merge them only after we recharter.
… I don't know why TallTed's tick is not green.
… In the DID WG, we are using a list of code owners.


Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
class-3 Class-3 change
Projects
Development

Successfully merging this pull request may close these issues.

blind spot in RDF to object conversion
5 participants