Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Appendix on Proof Sets/Chains: Clarity improvements #335

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

Wind4Greg
Copy link
Collaborator

@Wind4Greg Wind4Greg commented Feb 18, 2025

Editorial only. Informative Appendix. Fix wording to add missing explanatory text. It looks like some text got chopped on in the explanation of proof sets. This PR provides a fix.


Preview | Diff

@Wind4Greg Wind4Greg requested a review from TallTed February 18, 2025 19:12
@Wind4Greg Wind4Greg requested a review from msporny as a code owner February 18, 2025 19:12
Copy link
Member

@TallTed TallTed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tweaks for clarity

@msporny msporny added CR2 This item was processed during the second Candidate Recommendation Phase future labels Feb 26, 2025
@iherman
Copy link
Member

iherman commented Feb 26, 2025

The issue was discussed in a meeting on 2025-02-26

List of resolutions:

  • Resolution No. 1: Transition vc-data-model, vc-data-integrity, vc-di-eddsa, vc-di-ecdsa, vc-jose-cose (once PRs 331, 332, and 338 are merged), vc-bitstring-status-list, and cid-1.0 specifications to Proposed Recommendation.
View the transcript

1.1. Appendix on Proof Sets/Chains: Clarity improvements (pr vc-data-integrity#335)

See github pull request vc-data-integrity#335.

Brent Zundel: Ok, that means DI has no issues not marked future / horizontal review.
… There is a PR for clarification in an appendix.

Manu Sporny: I don't know how I missed this one.
… Taking a look.

Brent Zundel: It is a very small PR.

Manu Sporny: I can merge it.

Brent Zundel: We can mark this future and make it the first editorial one.
… I'll mark this future, it's fully in scope.

Manu Sporny: Yes, I just marked it that way.

Brent Zundel: Ok, good.
… VC-DI-EdDSA is next, no issues other than horizontal tracking, the implementation report shows sufficient experience and that rolls up to DI which we just looked at. This is ready to go.
… VC-DI-ECDSA is in a similar spot, there's an additional issue which is marked future and it's editorial. Again, sufficient implementations in the implementation report and that rolls up to DI as well.
… So also ready to go.
… VC-JOSE-COSE still has three open PRs.
… One of them is an echidna change, which I thought got merged but apparently did not. One to create a PR snapshot, which should definitely be merged so we have our snapshot.

Brent Zundel: https://github.com/w3c/vc-jose-cose/pulls.

Brent Zundel: Finally, there is a PR to add the revision history and changes since we went into Candidate Rec.

Manu Sporny: I suggest these are fairly editorial and if we make a proposal to move VC-JOSE-COSE to PR that we include text that says we'll merge the remaining PRs before the request is issued.

Brent Zundel: I'm ok with that. I want to note that the implementation report ... the VC-JOSE-COSE test suite implementation report shows sufficient implementations of every feature.
… We have at least two implementations for each feature. We were concerned about getting those in but now we have them.
… So VC-JOSE-COSE will be ready once those editorial PRs are merged and the snapshot is updated.
… The final one is BitstringStatusList.
… BitstringStatusList has no open PRs, the only issue is horizontal review tracking issue.
… As folks engaged with the test suite, in order to demonstrate that they had implemented some of the features that hadn't been tested by the other implementers, they ran into a minor issue.
… There is implementation experience that has been demonstrated, I don't believe it has been incorporated into the test suite report.

Manu Sporny: That's right. It hasn't been integrated into the test suite report but we have at least two implementers saying they implemented the "status message" mechanism and we can get that into the report before it goes out to the membership.

Brent Zundel: Cool. With that, BitstringStatusList is also ready to be moved into PR.
… If I counted right that's seven specs and that's what we're moving today.
… We need to indicate for VC-JOSE-COSE that ... do we understand that we're going to merge those last three PRs?

Manu Sporny: We should be explicit.

Brent Zundel: I will add a parenthetical comment.
… Any changes to the emoted proposal before we run it?

Proposed resolution: Transition vc-data-model, vc-data-integrity, vc-di-eddsa, vc-di-ecdsa, vc-jose-cose (once PRs 331, 332, and 338 are merged), vc-bitstring-status-list, and cid-1.0 specifications to Proposed Recommendation. (Brent Zundel)

Manu Sporny: +1.

Brent Zundel: +1.

Ted Thibodeau Jr.: +1.

Dave Longley: +1.

Will Abramson: +1.

David Chadwick: +1.

Hiroyuki Sano: +1.

Jennie Meier: +1.

Joe Andrieu: +1.

Benjamin Young: +1.

David Lehn: +1.

Denken Chen: +1.

Resolution #1: Transition vc-data-model, vc-data-integrity, vc-di-eddsa, vc-di-ecdsa, vc-jose-cose (once PRs 331, 332, and 338 are merged), vc-bitstring-status-list, and cid-1.0 specifications to Proposed Recommendation.

Brent Zundel: I have said it before and will say it again right now, that set of documents reflects an absolutely enormous amount of work that this group has done.
… We have had a lot of long and sometimes heated conversations and we are done with those. Fantastic! Absolutely fantastic, thank you everyone.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CR2 This item was processed during the second Candidate Recommendation Phase future
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants