Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove strict name validation on assert.rejects statements #133

Merged
merged 1 commit into from
Oct 17, 2024

Conversation

PatStLouis
Copy link
Collaborator

I had occurrences where my server was returning a different type of error than what the test suite was expecting (ex: returning an HTTPException instead of an HTTPError) and marked the test as failed even if my server behaved correctly. I wonder if checking for a specific type of error is too strict of a validation here?

Copy link
Member

@BigBlueHat BigBlueHat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems OK to me. That was likely my fault as I was hoping to make it clear what types of errors we were expecting...but given the way APIs jump around, I think you're right and that specificity likely isn't important.

@PatStLouis PatStLouis merged commit 82c0d71 into main Oct 17, 2024
2 checks passed
@PatStLouis PatStLouis deleted the remove-rejection-name-validation branch October 17, 2024 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants