Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests for interactions between validUntil and validFrom #55

Merged
merged 5 commits into from
Jan 4, 2024
Merged

Add tests for interactions between validUntil and validFrom #55

merged 5 commits into from
Jan 4, 2024

Conversation

aljones15
Copy link
Contributor

No description provided.

@aljones15 aljones15 self-assigned this Jan 2, 2024
@aljones15 aljones15 requested a review from BigBlueHat January 2, 2024 20:12
@aljones15 aljones15 force-pushed the valid-until-from-tests branch from 8881a46 to 4ee36d7 Compare January 3, 2024 17:24
@BigBlueHat BigBlueHat requested a review from JSAssassin January 3, 2024 20:43
JSAssassin
JSAssassin approved these changes Jan 3, 2024
View reviewed changes
Copy link
Contributor

@JSAssassin JSAssassin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if the PR is ready for review, I've approved it anyway since it LGTM!

Its need a changelog entry though. Also please mark the PR ready for review if it is. Thanks!

@aljones15 aljones15 marked this pull request as ready for review January 4, 2024 13:50
@aljones15 aljones15 force-pushed the valid-until-from-tests branch from 9d5d042 to 493e570 Compare January 4, 2024 20:10
@aljones15 aljones15 merged commit 9b5e2e2 into main Jan 4, 2024
2 checks passed
@aljones15 aljones15 deleted the valid-until-from-tests branch January 4, 2024 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JSAssassin JSAssassin JSAssassin approved these changes

@BigBlueHat BigBlueHat BigBlueHat approved these changes

Assignees

@aljones15 aljones15

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aljones15 @BigBlueHat @JSAssassin