Use endpoints class #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BigBlueHat
requested changes
Jan 8, 2024
Co-authored-by: BigBlueHat <[email protected]>
|
@BigBlueHat good catch can't believe I didn't see that. |
JSAssassin
reviewed
Jan 8, 2024
JSAssassin
approved these changes
Jan 8, 2024
Co-authored-by: Tashi D. Gyeltshen <[email protected]>
BigBlueHat
requested changes
Jan 8, 2024
README.md
Outdated
| - [VC 2.0 Context - https://www.w3.org/ns/credentials/v2](https://www.w3.org/ns/credentials/v2) | ||
| - [VC Examples Context - https://www.w3.org/ns/credentials/examples/v2](https://www.w3.org/ns/credentials/examples/v2) | ||
| - [Vc 2.0 Context - https://www.w3.org/ns/credentials/v2](https://www.w3.org/ns/credentials/v2) | ||
| - [Vc Examples Context - https://www.w3.org/ns/credentials/examples/v2](https://www.w3.org/ns/credentials/examples/v2) |
There was a problem hiding this comment.
Well...this takes the code style into the wrong place. 😃 These are for people, who typically abbreviate Verifiable Credentials as VC...and would read Vc as a typo. So, the README needs refixing.
There was a problem hiding this comment.
This should make the corrections asked for: eda2a3b
tests/data-generator.js
Outdated
| @@ -51,16 +56,16 @@ async function getKeys() { | |||
| } | |||
|
|
|||
| /** | |||
| * An extremely basic VP prover. This is not final | |||
| * An extremely basic Vp creator. This is not final | |||
There was a problem hiding this comment.
Again, these are human facing abbreviations, so need to stay all caps. Maybe a global search and replace got too greedy? 😀
There was a problem hiding this comment.
Suggested change
| * An extremely basic Vp creator. This is not final | |
| * An extremely basic VP creator. This is not final |
There was a problem hiding this comment.
I was actually just being thorough anyways here ya go: eda2a3b
BigBlueHat
approved these changes
Jan 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is clean up: it removes tons of unneeded stuff from the actual test suite and instead creates an Endpoints class that really helps make the suite cleaner and makes it almost more inline with the rest of the suites. It also moves the challenge generation to
data-generator.jsfurther decluttering the test file.