-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove mentions to media type parameters #1382
Conversation
a8e12cc
to
6e0ccbe
Compare
index.html
Outdated
@@ -4502,6 +4502,15 @@ <h3>Verification</h3> | |||
</ol> | |||
</li> | |||
<li> | |||
Ensure that the <var>result</var>.<var>mediaType</var> value is either | |||
`application/vc+ld+json` or `application/vp+ld+json` and does not contain any | |||
media type parameters, as defined in [[RFC6838]]. If the checks fail, set |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about protocols that need to signal profiles of this specification?
What guidance do we provide for profiling?
Will it be ok to add profile
in VCDM v3?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You requested that parameters are banned in this comment. I was implementing what you requested.
Data model "profiles" are currently signaled via @context
.
We could add profile
back in v3 by changing the algorithm and switching off of the @context
version.
Exactly what sort of profiles do you foresee?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it would be preferable to serve profiled data, without the need to sniff the context.
a profile parameter should be registered for application/vc+ld+json
and when present, the verification algorithm should reject verification calls for media types it does not understand.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So, when you said: "I prefer the validation / verification algorithm to explicitly prohibit parameters", you meant the opposite of that?
Please provide concrete examples of whatever you want to do, because it's not clear if you are trying to profile encoding mechanisms, securing mechanisms, data models, transport models, operational models, or something else. Media type parameters can affect all of those things, which is why it's often a bad idea to use them (it leads to a proliferation of non-interoperable profiles).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are we discussing V3 issues? Isn't this a bit premature when V2 is not in CR yet?
I must admit I am also lost what we want and what we do not want.
I also note that if we are talking about a new feature that has not been discussed before, that should automatically be considered as a V3 issue. We have been in feature freeze for V2 for quite a while now...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I also note that if we are talking about a new feature that has not been discussed before, that should automatically be considered as a V3 issue. We have been in feature freeze for V2 for quite a while now...
Agreed. The only reason I raised this PR is because @OR13 explicitly asked for it in a before-CR issue about the verification algorithm (which is only in scope due to the potential for an FO). It now sounds like the request has turned into a new feature request to use the profile
parameter.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To be clear, my original request was in relation to the media type registration request.
When requesting new media types, you need to consider if parameters are allowed.
Given that +ld+json
implies profile
, my request was to acknowledge this explicit.
If we are saying profile
is forbidden for vc+ld+json
, in the registration, the text in this PR is good to be merged as is.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hopefully the fediverse stops using profile
I hesitate rather a lot to ban use of a technology feature (here, media type parameters, specifically As in many spaces, it seems the adage "if you can't think of anything good to say, say nothing" applies. In other words, don't require that anyone/everyone use the thing you won't or can't use, but don't forbid others from using that same thing. At the moment, I'm a strong -0.99 and could easily be tipped over to a -1 and/or a formal objection on this proposed forbiddance without a much stronger argument than the conjecture that "allowing media type parameters might decrease VC interop" and that some folks don't like their taste. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are we forbidding things here?
The issue was discussed in a meeting on 2023-12-12
View the transcript2.3. Forbid use of media type parameters (pr vc-data-model#1382)See github pull request vc-data-model#1382. Manu Sporny: I thought Ted was a -0.99 and I agree.
Manu Sporny: This feels like a time sink.
Ted Thibodeau Jr.: Yes, please lets close this. Brent Zundel: dmitriz also noted he was +1 to close. |
This PR needs to be updated to remove mentions to media type parameters. |
The issue was discussed in a meeting on 2023-12-13
View the transcript2.9. Request profile parameter from
|
@jandrieu wrote:
Based on WG consensus during the last call, this PR no longer forbids (nor encourages) the use of media type parameters. |
Normative, multiple reviews, changes requested and made, no objections, merging. |
This PR addresses issue #1363 by ensuring that the use of media type parameters will result in a verification failure.
Preview | Diff