Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure created proof option is optional #73

Closed
dlongley opened this issue Jan 2, 2024 · 3 comments
Closed

Ensure created proof option is optional #73

dlongley opened this issue Jan 2, 2024 · 3 comments
Assignees
Labels
CR1 normative This item is a substantive or normative change. ready for pr

Comments

@dlongley
Copy link
Contributor

dlongley commented Jan 2, 2024

The current proof configuration algorithm seems to make created required instead of optional, this should be fixed.

@msporny msporny added normative This item is a substantive or normative change. CR1 labels Feb 9, 2024
@msporny msporny self-assigned this Jun 28, 2024
@msporny
Copy link
Member

msporny commented Jun 30, 2024

The created property is now optional:

https://w3c.github.io/vc-data-integrity/#proofs

The algorithms still need to be updated to ensure that created is optional (it shouldn't throw an error if it isn't specified).

@Wind4Greg
Copy link
Contributor

@msporny, whoops, the EdDSA spec is using the "old language" in the DataIntegrityProof section. I'll update it by the end of the day PDT to use language like that in the ECDSA spec.

@msporny
Copy link
Member

msporny commented Jul 15, 2024

PR #86 was raised and merged to address this issue. Closing.

@msporny msporny closed this as completed Jul 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CR1 normative This item is a substantive or normative change. ready for pr
Projects
None yet
Development

No branches or pull requests

3 participants